linux-kernel - Re: [PATCH] i2c: imx-lpi2c: fix build warning "function defined but not used"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <AM0PR0402MB393766FD0EC946FEA2E32819E8092@AM0PR0402MB3937.eurprd04.prod.outlook.com>
Date: Mon, 30 Dec 2024 02:05:50 +0000
From: Carlos Song <carlos.song@....com>
To: Andi Shyti <andi.shyti@...nel.org>
CC: Frank Li <frank.li@....com>, Aisheng Dong <aisheng.dong@....com>,
	"shawnguo@...nel.org" <shawnguo@...nel.org>, "s.hauer@...gutronix.de"
	<s.hauer@...gutronix.de>, "kernel@...gutronix.de" <kernel@...gutronix.de>,
	"festevam@...il.com" <festevam@...il.com>, "linux-i2c@...r.kernel.org"
	<linux-i2c@...r.kernel.org>, "imx@...ts.linux.dev" <imx@...ts.linux.dev>,
	"linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, kernel test robot <lkp@...el.com>
Subject: Re: [PATCH] i2c: imx-lpi2c: fix build warning "function defined but
 not used"



> -----Original Message-----
> From: Andi Shyti <andi.shyti@...nel.org>
> Sent: Sunday, December 29, 2024 5:01 AM
> To: Carlos Song <carlos.song@....com>
> Cc: Frank Li <frank.li@....com>; Aisheng Dong <aisheng.dong@....com>;
> shawnguo@...nel.org; s.hauer@...gutronix.de; kernel@...gutronix.de;
> festevam@...il.com; linux-i2c@...r.kernel.org; imx@...ts.linux.dev;
> linux-arm-kernel@...ts.infradead.org; linux-kernel@...r.kernel.org; kernel test
> robot <lkp@...el.com>
> Subject: [EXT] Re: [PATCH] i2c: imx-lpi2c: fix build warning "function defined but
> not used"
> 
> Caution: This is an external email. Please take care when clicking links or
> opening attachments. When in doubt, report the message using the 'Report this
> email' button
> 
> 
> Hi Carlos,
> 
> On Sat, Dec 28, 2024 at 09:53:22PM +0100, Andi Shyti wrote:
> > On Sat, Dec 28, 2024 at 05:08:52PM +0800, Carlos Song wrote:
> > > lpi2c_resume_noirq() and lpi2c_suspend_noirq() are defined but it
> > > maybe unused, so should add __maybe_unused to both functions to
> > > avoid build warning.
> > >
> > > Fixes: fa89723f7a78 ("i2c: imx-lpi2c: add target mode support")
> > > Reported-by: kernel test robot <lkp@...el.com>
> > > Closes:
> > > https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Flo
> > > re.kernel.org%2Foe-kbuild-all%2F202412280835.LRAV3z0g-lkp%40intel.co
> > >
> m%2F&data=05%7C02%7Ccarlos.song%40nxp.com%7C20350a7984e64a96359
> d08dd
> > >
> 2782c95b%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C638710164
> 87754
> > >
> 0710%7CUnknown%7CTWFpbGZsb3d8eyJFbXB0eU1hcGkiOnRydWUsIlYiOiIwLjA
> uMDA
> > >
> wMCIsIlAiOiJXaW4zMiIsIkFOIjoiTWFpbCIsIldUIjoyfQ%3D%3D%7C0%7C%7C%7C
> &s
> > >
> data=FR4jUHXmRZxQOnaBRkMsYV5toDEhfAsWatxTfoizbjo%3D&reserved=0
> > > Signed-off-by: Carlos Song <carlos.song@....com>
> >
> > yeah, I have different PM configuration to catch these kind of error
> > and I missed this.
> >
> > Rather than applying a fix over a recent patch, I am going to remove
> > your original patch and ask you to send a v7 of your
> > "imx-lpi2c: add target mode support".
> >
> > Is it OK with you?
> 
> I removed the patch and updated patchwork. I will be waiting for your v7.
> 
Hi, Andi, thank you very much! It helps a lot.:)

I will merge the fix to "imx-lpi2c: add target mode support" at V7 patch.

BR
Carlos Song

> Thanks,
> Andi