linux-kernel - Re: [PATCH v2] ALSA: ctxfi: Simplify dao_clear_{left,right}

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z3LAfa0cIY2eboNR@visitorckw-System-Product-Name>
Date: Mon, 30 Dec 2024 23:47:09 +0800
From: Kuan-Wei Chiu <visitorckw@...il.com>
To: Ethan Carter Edwards <ethan@...ancedwards.com>
Cc: tiwai@...e.de, tiwai@...e.com, perex@...ex.cz, arnd@...db.de,
	linux-sound@...r.kernel.org, linux-kernel@...r.kernel.org,
	ryan_richards@...ativelabs.com, wychay@....creative.com,
	David Laight <david.laight.linux@...il.com>
Subject: Re: [PATCH v2] ALSA: ctxfi: Simplify dao_clear_{left,right}_input()
 functions

Hi Ethan,

Thank you for your patch. However, there are a few issues:

On Mon, Dec 30, 2024 at 03:32:58PM +0000, Ethan Carter Edwards wrote:
> There was a lote of code duplication in the dao_clear_left_input() and
> dao_clear_right_input() functions. A new function, dao_clear_input(),
> was created and now the left and right functions call it instead of
> repeating themselves.
> 
> Link: https://lore.kernel.org/lkml/NyKCr2VHK_xCQDwNxFKKx2LVd2d_AC2f2j4eAvnD9uRPtb50i2AruCLOp6mHxsGiyYJ0Tgd3Z50Oy1JTi5gPhjd2WQM2skrv7asp3fLl8HU=@ethancedwards.com/
>
Please move the Link: tag to the SoB area without an empty line.

> Signed-off-by: Ethan Carter Edwards <ethan@...ancedwards.com>
> Co-developed-by: David Laight <david.laight.linux@...il.com>

The Co-developed-by: tag should be immediately followed by the
co-author's Signed-off-by: tag. Additionally, the last Signed-off-by:
tag must always belong to the patch submitter.

See: https://docs.kernel.org/process/submitting-patches.html#when-to-use-acked-by-cc-and-co-developed-by

Regards,
Kuan-Wei