linux-kernel - Re: [PATCH v2 2/2] selftests: coredump: Add stackdump test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202412301041.E4D0C5D8C@keescook>
Date: Mon, 30 Dec 2024 10:43:39 -0800
From: Kees Cook <kees@...nel.org>
To: Nam Cao <namcao@...utronix.de>
Cc: Shuah Khan <shuah@...nel.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Oleg Nesterov <oleg@...hat.com>,
	Dylan Hatch <dylanbhatch@...gle.com>,
	"Eric W . Biederman" <ebiederm@...ssion.com>,
	John Ogness <john.ogness@...utronix.de>,
	linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org,
	linux-kselftest@...r.kernel.org
Subject: Re: [PATCH v2 2/2] selftests: coredump: Add stackdump test

On Mon, Dec 30, 2024 at 11:17:31AM +0100, Nam Cao wrote:
> Add a test which checks that the kstkesp field in /proc/pid/stat can be
> read for all threads of a coredumping process.
> 
> For full details including the motivation for this test and how it works,
> see the README file added by this commit.

This is great! One tiny nit below...

> +#define STACKDUMP_FILE "/tmp/kselftest_stackdump"

Please move this to the local directory (and have the Makefile and/or
test itself clean it up). (Or use mkstemp()) I don't want to have "well
known" filenames appearing in /tmp for selftests.

-Kees

-- 
Kees Cook