linux-kernel - Re: [PATCH v2 1/3] dt-bindings: mailbox: mediatek: Add apu-mailbox dt-bindings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <vsdkjbedy5zm6iz6jtjgoynove2u6tgd4al3b6v5xzvrr3twm6@cmy6poq3le53>
Date: Tue, 31 Dec 2024 09:27:16 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: "Karl.Li" <karl.li@...iatek.com>
Cc: Jassi Brar <jassisinghbrar@...il.com>, Rob Herring <robh@...nel.org>, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
	Matthias Brugger <matthias.bgg@...il.com>, 
	AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>, linux-kernel@...r.kernel.org, devicetree@...r.kernel.org, 
	linux-arm-kernel@...ts.infradead.org, linux-mediatek@...ts.infradead.org, 
	Chungying Lu <chungying.lu@...iatek.com>, Chien-Chih Tseng <Chien-Chih.Tseng@...iatek.com>, 
	Andy Teng <Andy.Teng@...iatek.com>, Chen-Yu Tsai <wenst@...omium.org>, 
	Project_Global_Chrome_Upstream_Group@...iatek.com
Subject: Re: [PATCH v2 1/3] dt-bindings: mailbox: mediatek: Add apu-mailbox
 dt-bindings

On Mon, Dec 30, 2024 at 11:43:35AM +0800, Karl.Li wrote:
> From: Karl Li <karl.li@...iatek.com>
> 
> Add devicetree binding for apu-mailbox.

A nit, subject: drop second/last, redundant "dt-bindings". The
"dt-bindings" prefix is already stating that these are bindings.
See also:
https://elixir.bootlin.com/linux/v6.7-rc8/source/Documentation/devicetree/bindings/submitting-patches.rst#L18

I already asked for this.

> 
> MediaTek APU (AI Processing Unit) is a microcontroller unit
> designed for AI acceleration tasks. The MediaTek APU-Mailbox
> facilitates communication with the APU microcontroller.

Please wrap commit message according to Linux coding style / submission
process (neither too early nor over the limit):
https://elixir.bootlin.com/linux/v6.4-rc1/source/Documentation/process/submitting-patches.rst#L597




> 
> Signed-off-by: Karl Li <karl.li@...iatek.com>
> ---
>  .../mailbox/mediatek,apu-mailbox.yaml         | 60 +++++++++++++++++++
>  1 file changed, 60 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/mailbox/mediatek,apu-mailbox.yaml
> 
> diff --git a/Documentation/devicetree/bindings/mailbox/mediatek,apu-mailbox.yaml b/Documentation/devicetree/bindings/mailbox/mediatek,apu-mailbox.yaml
> new file mode 100644
> index 000000000000..fdb0dec5fb78
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mailbox/mediatek,apu-mailbox.yaml


Use compatible as filename.


Best regards,
Krzysztof