linux-kernel - Re: [PATCH v3 2/2] iio: veml3235: fix scale to conform to ABI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <D6PR0XZ27Z67.1IJEM2DOL18QY@gmail.com>
Date: Tue, 31 Dec 2024 09:39:03 +0100
From: "Javier Carrasco" <javier.carrasco.cruz@...il.com>
To: "Javier Carrasco" <javier.carrasco.cruz@...il.com>, "Matti Vaittinen"
 <mazziesaccount@...il.com>, "Jonathan Cameron" <jic23@...nel.org>,
 "Lars-Peter Clausen" <lars@...afoo.de>
Cc: <linux-iio@...r.kernel.org>, <linux-kernel@...r.kernel.org>, "Jonathan
 Cameron" <Jonathan.Cameron@...wei.com>
Subject: Re: [PATCH v3 2/2] iio: veml3235: fix scale to conform to ABI

On Mon Dec 30, 2024 at 4:13 PM CET, Javier Carrasco wrote:
> The current scale is not ABI-compliant as it is just the sensor gain
> instead of the value that acts as a multiplier to be applied to the raw
> value (there is no offset).
>
> Use the iio-gts helpers to obtain the proper scale values according to
> the gain and integration time to match the resolution tables from the
> datasheet. When at it, use 'scale' instead of 'gain' consistently for
> the get/set functions to avoid misunderstandings.
>
> Fixes: c5a23f80c164 ("iio: light: add support for veml3235")
> Reviewed-by: Matti Vaittinen <mazziesaccount@...il.com>
> Signed-off-by: Javier Carrasco <javier.carrasco.cruz@...il.com>
> ---
>  drivers/iio/light/Kconfig    |   1 +
>  drivers/iio/light/veml3235.c | 237 +++++++++++++++++++++++--------------------
>  2 files changed, 130 insertions(+), 108 deletions(-)
>

@Jonathan, if you apply this patch in its current form, could you please
fix the message from "iio: veml3235:..." to "iio: light: veml3235:..."?
I just noticed that the "light:" bit is missing.
I can send a new version if that's preferred.

The applied patches from this series did not have this issue.

Thanks and best regards,
Javier Carrasco