linux-kernel - Re: [PATCH] RDMA/rtrs: server: Ensure 'ib

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <173565158807.103567.13486575461708378140.b4-ty@kernel.org>
Date: Tue, 31 Dec 2024 08:26:28 -0500
From: Leon Romanovsky <leon@...nel.org>
To: linux-rdma@...r.kernel.org, Li Zhijian <lizhijian@...itsu.com>
Cc: haris.iqbal@...os.com, Jack Wang <jinpu.wang@...os.com>, 
 Jason Gunthorpe <jgg@...pe.ca>, linux-kernel@...r.kernel.org, 
 Zhu Yanjun <zyjzyj2000@...il.com>, shinichiro.kawasaki@....com
Subject: Re: [PATCH] RDMA/rtrs: server: Ensure 'ib_sge list' is accessible


On Tue, 31 Dec 2024 09:34:16 +0800, Li Zhijian wrote:
> Move the declaration of the 'ib_sge list' variable outside the
> 'always_invalidate' block to ensure it remains accessible for use
> throughout the function.
> 
> Previously, 'ib_sge list' was declared within the 'always_invalidate'
> block, limiting its accessibility, then caused a
> 'BUG: kernel NULL pointer dereference'[1].
>  ? __die_body.cold+0x19/0x27
>  ? page_fault_oops+0x15a/0x2d0
>  ? search_module_extables+0x19/0x60
>  ? search_bpf_extables+0x5f/0x80
>  ? exc_page_fault+0x7e/0x180
>  ? asm_exc_page_fault+0x26/0x30
>  ? memcpy_orig+0xd5/0x140
>  rxe_mr_copy+0x1c3/0x200 [rdma_rxe]
>  ? rxe_pool_get_index+0x4b/0x80 [rdma_rxe]
>  copy_data+0xa5/0x230 [rdma_rxe]
>  rxe_requester+0xd9b/0xf70 [rdma_rxe]
>  ? finish_task_switch.isra.0+0x99/0x2e0
>  rxe_sender+0x13/0x40 [rdma_rxe]
>  do_task+0x68/0x1e0 [rdma_rxe]
>  process_one_work+0x177/0x330
>  worker_thread+0x252/0x390
>  ? __pfx_worker_thread+0x10/0x10
> 
> [...]

Applied, thanks!

[1/1] RDMA/rtrs: server: Ensure 'ib_sge list' is accessible
      https://git.kernel.org/rdma/rdma/c/bc0f6099b7c272

Best regards,
-- 
Leon Romanovsky <leon@...nel.org>