linux-kernel - RE: [PATCH 3/3] clk: xilinx: vcu: unregister pll

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <CH2PR12MB487569DF2CB4E5B62A221227E50A2@CH2PR12MB4875.namprd12.prod.outlook.com>
Date: Tue, 31 Dec 2024 14:16:29 +0000
From: "Visavalia, Rohit" <rohit.visavalia@....com>
To: Stephen Boyd <sboyd@...nel.org>, "Simek, Michal" <michal.simek@....com>,
	"mturquette@...libre.com" <mturquette@...libre.com>, "Sagar, Vishal"
	<vishal.sagar@....com>
CC: "javier.carrasco.cruz@...il.com" <javier.carrasco.cruz@...il.com>,
	"geert+renesas@...der.be" <geert+renesas@...der.be>,
	"u.kleine-koenig@...libre.com" <u.kleine-koenig@...libre.com>,
	"linux-clk@...r.kernel.org" <linux-clk@...r.kernel.org>,
	"linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>
Subject: RE: [PATCH 3/3] clk: xilinx: vcu: unregister pll_post only if
 registered correctly

Hi Stephen,

Thanks for the review.

>-----Original Message-----
>From: Stephen Boyd <sboyd@...nel.org>
>Sent: Tuesday, December 31, 2024 6:07 AM
>To: Visavalia, Rohit <rohit.visavalia@....com>; Simek, Michal
><michal.simek@....com>; mturquette@...libre.com; Sagar, Vishal
><vishal.sagar@....com>
>Cc: javier.carrasco.cruz@...il.com; geert+renesas@...der.be; u.kleine-
>koenig@...libre.com; linux-clk@...r.kernel.org; linux-arm-
>kernel@...ts.infradead.org; linux-kernel@...r.kernel.org; Visavalia, Rohit
><rohit.visavalia@....com>
>Subject: Re: [PATCH 3/3] clk: xilinx: vcu: unregister pll_post only if registered
>correctly
>
>Quoting Rohit Visavalia (2024-12-26 04:20:23)
>> If registration of pll_post is failed, it will be set to NULL or ERR,
>> unregistering same will fail with following call trace:
>>
>> Unable to handle kernel NULL pointer dereference at virtual address
>> 008 pc : clk_hw_unregister+0xc/0x20 lr :
>> clk_hw_unregister_fixed_factor+0x18/0x30
>> sp : ffff800011923850
>> ...
>> Call trace:
>>  clk_hw_unregister+0xc/0x20
>>  clk_hw_unregister_fixed_factor+0x18/0x30
>>  xvcu_unregister_clock_provider+0xcc/0xf4 [xlnx_vcu]
>> xvcu_probe+0x2bc/0x53c [xlnx_vcu]
>>
>> Signed-off-by: Rohit Visavalia <rohit.visavalia@....com>
>
>Please add a Fixes tag, and put fixes earlier in the series so they can be applied
>while other patches go through review.
I will take care in next patch series.

Thanks
Rohit