linux-kernel - Re: [PATCH] drm/ssd130x: Set SPI .id_table to prevent an SPI core warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <874j2jkcnt.fsf@minerva.mail-host-address-is-not-set>
Date: Tue, 31 Dec 2024 18:03:34 +0100
From: Javier Martinez Canillas <javierm@...hat.com>
To: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
Cc: linux-kernel@...r.kernel.org, Mark Brown <broonie@...nel.org>, David
 Airlie <airlied@...il.com>, Maarten Lankhorst
 <maarten.lankhorst@...ux.intel.com>, Maxime Ripard <mripard@...nel.org>,
 Simona Vetter <simona@...ll.ch>, Thomas Zimmermann <tzimmermann@...e.de>,
 dri-devel@...ts.freedesktop.org
Subject: Re: [PATCH] drm/ssd130x: Set SPI .id_table to prevent an SPI core
 warning

Dmitry Baryshkov <dmitry.baryshkov@...aro.org> writes:

> On Tue, Dec 31, 2024 at 04:34:34PM +0100, Javier Martinez Canillas wrote:
>> Dmitry Baryshkov <dmitry.baryshkov@...aro.org> writes:
>> 
>> Hello Dmitry,
>> 
>> > On Tue, Dec 31, 2024 at 12:44:58PM +0100, Javier Martinez Canillas wrote:
>
> [...]
>
>> >> Since the check is done even for built-in drivers, drop the condition to
>> >> only define the ID table when the driver is built as a module. Finally,
>> >> rename the variable to use the "_spi_id" convention used for ID tables.
>> >> 
>> >> Signed-off-by: Javier Martinez Canillas <javierm@...hat.com>
>> >
>> > Fixes: 74373977d2ca ("drm/solomon: Add SSD130x OLED displays SPI support")
>> >
>> 
>> I was on the fence about adding a Fixes: tag due a) the issue being there
>> from the beginning as you pointed out and b) the warning being harmless.
>> 
>> But I'll add it to v2 or just before pushing it to drm-misc-next.
>
> Just before pushing is enough. dim b4-shazam can do that for you.
>

Yeah, I meant in case that I post a v2. I'll wait a few days before
pushing in case someone else chimes in. Thanks again!

-- 
Best regards,

Javier Martinez Canillas
Core Platforms
Red Hat