| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <d3174dce-868c-4a42-9a5c-2b947ae88d18@wanadoo.fr>
Date: Tue, 31 Dec 2024 18:49:29 +0100
From: Christophe JAILLET <christophe.jaillet@...adoo.fr>
To: Mathieu Dubois-Briand <mathieu.dubois-briand@...tlin.com>,
Lee Jones <lee@...nel.org>, Rob Herring <robh@...nel.org>,
Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
<conor+dt@...nel.org>, Kamel Bouhara <kamel.bouhara@...tlin.com>,
Linus Walleij <linus.walleij@...aro.org>, Bartosz Golaszewski
<brgl@...ev.pl>, Dmitry Torokhov <dmitry.torokhov@...il.com>,
Uwe Kleine-König <ukleinek@...nel.org>
Cc: devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
linux-gpio@...r.kernel.org, linux-input@...r.kernel.org,
linux-pwm@...r.kernel.org, Grégory Clement
<gregory.clement@...tlin.com>,
Thomas Petazzoni <thomas.petazzoni@...tlin.com>
Subject: Re: [PATCH v2 6/7] input: misc: Add support for MAX7360 rotary
Le 23/12/2024 à 17:42, Mathieu Dubois-Briand a écrit :
> Add driver for Maxim Integrated MAX7360 rotary encoder controller,
> supporting a single rotary switch.
>
> Signed-off-by: Mathieu Dubois-Briand <mathieu.dubois-briand@...tlin.com>
...
> +static irqreturn_t max7360_rotary_irq(int irq, void *data)
> +{
> + struct max7360_rotary *max7360_rotary = data;
> + int val;
> + int ret;
> +
> + ret = regmap_read(max7360_rotary->regmap, MAX7360_REG_RTR_CNT, &val);
> + if (ret < 0) {
> + dev_err(&max7360_rotary->input->dev,
> + "Failed to read rotary counter");
Missing \n.
> + return IRQ_NONE;
> + }
> +
> + if (val == 0) {
> + dev_dbg(&max7360_rotary->input->dev,
> + "Got a spurious interrupt");
Missing \n.
> +
> + return IRQ_NONE;
> + }
> +
> + input_report_rel(max7360_rotary->input, max7360_rotary->axis,
> + (int8_t)val);
> + input_sync(max7360_rotary->input);
> +
> + return IRQ_HANDLED;
> +}
> +
> +static int max7360_rotary_hw_init(struct max7360_rotary *max7360_rotary)
> +{
> + int val;
> + int ret;
> +
> + ret = regmap_write_bits(max7360_rotary->regmap, MAX7360_REG_GPIOCFG,
> + MAX7360_GPIO_CFG_RTR_EN,
> + MAX7360_GPIO_CFG_RTR_EN);
> + if (ret) {
> + dev_err(&max7360_rotary->input->dev,
> + "Failed to enable max7360 rotary encoder");
Missing \n.
> + return ret;
> + }
> +
> + val = FIELD_PREP(MAX7360_ROT_DEBOUNCE, max7360_rotary->debounce_ms) |
> + FIELD_PREP(MAX7360_ROT_INTCNT, 1) | MAX7360_ROT_INTCNT_DLY;
> + ret = regmap_write(max7360_rotary->regmap, MAX7360_REG_RTRCFG, val);
> + if (ret) {
> + dev_err(&max7360_rotary->input->dev,
> + "Failed to set max7360 rotary encoder configuration");
Missing \n.
> + return ret;
> + }
> +
> + return 0;
> +}
> +
> +static int max7360_rotary_probe(struct platform_device *pdev)
> +{
> + struct max7360_rotary *max7360_rotary;
> + struct input_dev *input;
> + int irq;
> + int ret;
> +
> + if (!pdev->dev.parent)
> + return dev_err_probe(&pdev->dev, -ENODEV, "No parent device\n");
> +
> + ret = max7360_port_pin_request(pdev->dev.parent, MAX7360_PORT_RTR_PIN,
> + true);
> + if (ret)
> + dev_err_probe(&pdev->dev, ret,
> + "Could not request rotary pin\n");
Missing return or done on purpose?
> +
> + irq = platform_get_irq_byname(to_platform_device(pdev->dev.parent),
> + "inti");
> + if (irq < 0)
> + return irq;
> +
> + max7360_rotary = devm_kzalloc(&pdev->dev, sizeof(*max7360_rotary),
> + GFP_KERNEL);
> + if (!max7360_rotary)
> + return -ENOMEM;
> +
> + max7360_rotary->regmap = dev_get_regmap(pdev->dev.parent, NULL);
> + if (!max7360_rotary->regmap)
> + dev_err_probe(&pdev->dev, -ENODEV,
> + "Could not get parent regmap\n");
> +
> + device_property_read_u32(pdev->dev.parent, "linux,axis",
> + &max7360_rotary->axis);
> + device_property_read_u32(pdev->dev.parent, "rotary-debounce-delay-ms",
> + &max7360_rotary->debounce_ms);
> + if (max7360_rotary->debounce_ms > MAX7360_ROT_DEBOUNCE_MAX)
> + return dev_err_probe(&pdev->dev, -EINVAL,
> + "Invalid debounce timing: %u\n",
> + max7360_rotary->debounce_ms);
> +
> + input = devm_input_allocate_device(&pdev->dev);
> + if (!input)
> + return dev_err_probe(&pdev->dev, -ENOMEM,
> + "Failed to allocate input device\n");
Not sure an error message is needed.
> +
> + max7360_rotary->input = input;
> +
> + input->id.bustype = BUS_I2C;
> + input->name = pdev->name;
> + input->dev.parent = &pdev->dev;
> +
> + input_set_capability(input, EV_REL, max7360_rotary->axis);
> + input_set_drvdata(input, max7360_rotary);
> +
> + ret = devm_request_threaded_irq(&pdev->dev, irq, NULL,
> + max7360_rotary_irq,
> + IRQF_TRIGGER_LOW | IRQF_ONESHOT | IRQF_SHARED,
> + "max7360-rotary", max7360_rotary);
> + if (ret)
> + return dev_err_probe(&pdev->dev, ret,
> + "Failed to register interrupt: %d\n", ret);
No need to duplicate ret.
> +
> + ret = input_register_device(input);
> + if (ret)
> + return dev_err_probe(&pdev->dev, ret,
> + "Could not register input device: %d\n",
> + ret);
No need to duplicate ret.
> +
> + platform_set_drvdata(pdev, max7360_rotary);
> +
> + device_init_wakeup(&pdev->dev, true);
> + ret = dev_pm_set_wake_irq(&pdev->dev, irq);
> + if (ret)
> + dev_warn(&pdev->dev, "Failed to set up wakeup irq: %d\n", ret);
> +
> + ret = max7360_rotary_hw_init(max7360_rotary);
> + if (ret)
> + return dev_err_probe(&pdev->dev, ret,
> + "Failed to initialize max7360 rotary\n");
> +
> + return 0;
> +}
CJ
Powered by blists - more mailing lists