[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <5227cdd506bcb0239657216bd36de12f.sboyd@kernel.org>
Date: Mon, 30 Dec 2024 16:39:23 -0800
From: Stephen Boyd <sboyd@...nel.org>
To: Rohit Visavalia <rohit.visavalia@....com>, michal.simek@....com, mturquette@...libre.com, vishal.sagar@....com
Cc: javier.carrasco.cruz@...il.com, geert+renesas@...der.be, u.kleine-koenig@...libre.com, linux-clk@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org, Rohit Visavalia <rohit.visavalia@....com>
Subject: Re: [PATCH 1/3] clk: xilinx: vcu: Update vcu init/reset sequence
Quoting Rohit Visavalia (2024-12-26 04:20:21)
> diff --git a/drivers/clk/xilinx/xlnx_vcu.c b/drivers/clk/xilinx/xlnx_vcu.c
> index 81501b48412e..f294a2398cb4 100644
> --- a/drivers/clk/xilinx/xlnx_vcu.c
> +++ b/drivers/clk/xilinx/xlnx_vcu.c
> @@ -676,6 +679,24 @@ static int xvcu_probe(struct platform_device *pdev)
> * Bit 0 : Gasket isolation
> * Bit 1 : put VCU out of reset
> */
> + xvcu->reset_gpio = devm_gpiod_get_optional(&pdev->dev, "reset",
> + GPIOD_OUT_LOW);
> + if (IS_ERR(xvcu->reset_gpio)) {
> + ret = PTR_ERR(xvcu->reset_gpio);
> + dev_err(&pdev->dev, "failed to get reset gpio for vcu.\n");
Use dev_err_probe() and friends.
> + goto error_get_gpio;
> + }
> +
> + if (xvcu->reset_gpio) {
> + gpiod_set_value(xvcu->reset_gpio, 0);
> + /* min 2 clock cycle of vcu pll_ref, slowest freq is 33.33KHz */
> + usleep_range(60, 120);
> + gpiod_set_value(xvcu->reset_gpio, 1);
> + usleep_range(60, 120);
> + } else {
> + dev_warn(&pdev->dev, "No reset gpio info from dts for vcu. This may lead to incorrect functionality if VCU isolation is removed post initialization.\n");
Is it 'vcu' or 'VCU'? Pick one please. Also, this is going to be an
unfixable warning message if the reset isn't there. Why have this
warning at all?
Powered by blists - more mailing lists