| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <202501011159.P6GIMpIk-lkp@intel.com>
Date: Wed, 1 Jan 2025 11:50:50 +0800
From: kernel test robot <lkp@...el.com>
To: Qiuxu Zhuo <qiuxu.zhuo@...el.com>
Cc: oe-kbuild-all@...ts.linux.dev, linux-kernel@...r.kernel.org,
Borislav Petkov <bp@...e.de>, Tony Luck <tony.luck@...el.com>
Subject: drivers/edac/skx_common.c:309:79: warning: '_DIMM#' directive output
may be truncated writing 6 bytes into a region of size between 0 and 9
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: ccb98ccef0e543c2bd4ef1a72270461957f3d8d0
commit: 98f2fc829e3b55a0ff1b82753fc1e10941535cb9 EDAC, skx_edac: Delete duplicated code
date: 6 years ago
config: x86_64-rhel-8.3-rust (https://download.01.org/0day-ci/archive/20250101/202501011159.P6GIMpIk-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250101/202501011159.P6GIMpIk-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202501011159.P6GIMpIk-lkp@intel.com/
All warnings (new ones prefixed by >>):
drivers/edac/skx_common.c: In function 'skx_mce_output_error':
drivers/edac/skx_common.c:470:15: warning: variable 'type' set but not used [-Wunused-but-set-variable]
470 | char *type, *optype;
| ^~~~
drivers/edac/skx_common.c: In function 'skx_get_dimm_info':
>> drivers/edac/skx_common.c:309:79: warning: '_DIMM#' directive output may be truncated writing 6 bytes into a region of size between 0 and 9 [-Wformat-truncation=]
309 | snprintf(dimm->label, sizeof(dimm->label), "CPU_SrcID#%u_MC#%u_Chan#%u_DIMM#%u",
| ^~~~~~
drivers/edac/skx_common.c:309:52: note: using the range [0, 4294967295] for directive argument
309 | snprintf(dimm->label, sizeof(dimm->label), "CPU_SrcID#%u_MC#%u_Chan#%u_DIMM#%u",
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/edac/skx_common.c:309:9: note: 'snprintf' output between 31 and 53 bytes into a destination of size 32
309 | snprintf(dimm->label, sizeof(dimm->label), "CPU_SrcID#%u_MC#%u_Chan#%u_DIMM#%u",
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
310 | imc->src_id, imc->lmc, chan, dimmno);
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/edac/skx_common.c: In function 'skx_get_nvdimm_info':
drivers/edac/skx_common.c:357:79: warning: '_DIMM#' directive output may be truncated writing 6 bytes into a region of size between 0 and 9 [-Wformat-truncation=]
357 | snprintf(dimm->label, sizeof(dimm->label), "CPU_SrcID#%u_MC#%u_Chan#%u_DIMM#%u",
| ^~~~~~
drivers/edac/skx_common.c:357:52: note: using the range [0, 4294967295] for directive argument
357 | snprintf(dimm->label, sizeof(dimm->label), "CPU_SrcID#%u_MC#%u_Chan#%u_DIMM#%u",
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/edac/skx_common.c:357:9: note: 'snprintf' output between 31 and 53 bytes into a destination of size 32
357 | snprintf(dimm->label, sizeof(dimm->label), "CPU_SrcID#%u_MC#%u_Chan#%u_DIMM#%u",
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
358 | imc->src_id, imc->lmc, chan, dimmno);
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
vim +309 drivers/edac/skx_common.c
88a242c9874044 Qiuxu Zhuo 2019-01-30 277
88a242c9874044 Qiuxu Zhuo 2019-01-30 278 int skx_get_dimm_info(u32 mtr, u32 amap, struct dimm_info *dimm,
88a242c9874044 Qiuxu Zhuo 2019-01-30 279 struct skx_imc *imc, int chan, int dimmno)
88a242c9874044 Qiuxu Zhuo 2019-01-30 280 {
88a242c9874044 Qiuxu Zhuo 2019-01-30 281 int banks = 16, ranks, rows, cols, npages;
88a242c9874044 Qiuxu Zhuo 2019-01-30 282 u64 size;
88a242c9874044 Qiuxu Zhuo 2019-01-30 283
88a242c9874044 Qiuxu Zhuo 2019-01-30 284 ranks = numrank(mtr);
88a242c9874044 Qiuxu Zhuo 2019-01-30 285 rows = numrow(mtr);
88a242c9874044 Qiuxu Zhuo 2019-01-30 286 cols = numcol(mtr);
88a242c9874044 Qiuxu Zhuo 2019-01-30 287
88a242c9874044 Qiuxu Zhuo 2019-01-30 288 /*
88a242c9874044 Qiuxu Zhuo 2019-01-30 289 * Compute size in 8-byte (2^3) words, then shift to MiB (2^20)
88a242c9874044 Qiuxu Zhuo 2019-01-30 290 */
88a242c9874044 Qiuxu Zhuo 2019-01-30 291 size = ((1ull << (rows + cols + ranks)) * banks) >> (20 - 3);
88a242c9874044 Qiuxu Zhuo 2019-01-30 292 npages = MiB_TO_PAGES(size);
88a242c9874044 Qiuxu Zhuo 2019-01-30 293
88a242c9874044 Qiuxu Zhuo 2019-01-30 294 edac_dbg(0, "mc#%d: channel %d, dimm %d, %lld MiB (%d pages) bank: %d, rank: %d, row: 0x%x, col: 0x%x\n",
88a242c9874044 Qiuxu Zhuo 2019-01-30 295 imc->mc, chan, dimmno, size, npages,
88a242c9874044 Qiuxu Zhuo 2019-01-30 296 banks, 1 << ranks, rows, cols);
88a242c9874044 Qiuxu Zhuo 2019-01-30 297
88a242c9874044 Qiuxu Zhuo 2019-01-30 298 imc->chan[chan].dimms[dimmno].close_pg = GET_BITFIELD(mtr, 0, 0);
88a242c9874044 Qiuxu Zhuo 2019-01-30 299 imc->chan[chan].dimms[dimmno].bank_xor_enable = GET_BITFIELD(mtr, 9, 9);
88a242c9874044 Qiuxu Zhuo 2019-01-30 300 imc->chan[chan].dimms[dimmno].fine_grain_bank = GET_BITFIELD(amap, 0, 0);
88a242c9874044 Qiuxu Zhuo 2019-01-30 301 imc->chan[chan].dimms[dimmno].rowbits = rows;
88a242c9874044 Qiuxu Zhuo 2019-01-30 302 imc->chan[chan].dimms[dimmno].colbits = cols;
88a242c9874044 Qiuxu Zhuo 2019-01-30 303
88a242c9874044 Qiuxu Zhuo 2019-01-30 304 dimm->nr_pages = npages;
88a242c9874044 Qiuxu Zhuo 2019-01-30 305 dimm->grain = 32;
88a242c9874044 Qiuxu Zhuo 2019-01-30 306 dimm->dtype = get_width(mtr);
88a242c9874044 Qiuxu Zhuo 2019-01-30 307 dimm->mtype = MEM_DDR4;
88a242c9874044 Qiuxu Zhuo 2019-01-30 308 dimm->edac_mode = EDAC_SECDED; /* likely better than this */
88a242c9874044 Qiuxu Zhuo 2019-01-30 @309 snprintf(dimm->label, sizeof(dimm->label), "CPU_SrcID#%u_MC#%u_Chan#%u_DIMM#%u",
88a242c9874044 Qiuxu Zhuo 2019-01-30 310 imc->src_id, imc->lmc, chan, dimmno);
88a242c9874044 Qiuxu Zhuo 2019-01-30 311
88a242c9874044 Qiuxu Zhuo 2019-01-30 312 return 1;
88a242c9874044 Qiuxu Zhuo 2019-01-30 313 }
88a242c9874044 Qiuxu Zhuo 2019-01-30 314
:::::: The code at line 309 was first introduced by commit
:::::: 88a242c9874044740ab990d4fccba8bb90cb924b EDAC, skx_common: Separate common code out from skx_edac
:::::: TO: Qiuxu Zhuo <qiuxu.zhuo@...el.com>
:::::: CC: Borislav Petkov <bp@...e.de>
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
Powered by blists - more mailing lists