linux-kernel - Re: [PATCH] KVM: SVM: Use str_enabled_disabled() helper in sev_hardware

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6a769aff-b01b-412b-af01-85ae210a30f5@amd.com>
Date: Thu, 2 Jan 2025 14:02:58 +0530
From: Nikunj A Dadhania <nikunj@....com>
To: Thorsten Blum <thorsten.blum@...ux.dev>,
 Sean Christopherson <seanjc@...gle.com>, Paolo Bonzini
 <pbonzini@...hat.com>, Thomas Gleixner <tglx@...utronix.de>,
 Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>,
 Dave Hansen <dave.hansen@...ux.intel.com>, x86@...nel.org,
 "H. Peter Anvin" <hpa@...or.com>
Cc: kvm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] KVM: SVM: Use str_enabled_disabled() helper in
 sev_hardware_setup()

On 12/27/2024 3:14 PM, Thorsten Blum wrote:
> Remove hard-coded strings by using the str_enabled_disabled() helper
> function.
> 
> Signed-off-by: Thorsten Blum <thorsten.blum@...ux.dev>

Looks good to me.

Reviewed-by: Nikunj A Dadhania <nikunj@....com>

> ---
>  arch/x86/kvm/svm/sev.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/x86/kvm/svm/sev.c b/arch/x86/kvm/svm/sev.c
> index 943bd074a5d3..87ed8cde68a7 100644
> --- a/arch/x86/kvm/svm/sev.c
> +++ b/arch/x86/kvm/svm/sev.c
> @@ -3051,11 +3051,11 @@ void __init sev_hardware_setup(void)
>  			min_sev_asid, max_sev_asid);
>  	if (boot_cpu_has(X86_FEATURE_SEV_ES))
>  		pr_info("SEV-ES %s (ASIDs %u - %u)\n",
> -			sev_es_supported ? "enabled" : "disabled",
> +			str_enabled_disabled(sev_es_supported),
>  			min_sev_asid > 1 ? 1 : 0, min_sev_asid - 1);
>  	if (boot_cpu_has(X86_FEATURE_SEV_SNP))
>  		pr_info("SEV-SNP %s (ASIDs %u - %u)\n",
> -			sev_snp_supported ? "enabled" : "disabled",
> +			str_enabled_disabled(sev_snp_supported),
>  			min_sev_asid > 1 ? 1 : 0, min_sev_asid - 1);
>  
>  	sev_enabled = sev_supported;