linux-kernel - Re: [PATCH] crypto: vmac - remove unused VMAC algorithm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <86e3502f-5d24-4779-9d3b-3cd79288fa0d@gmail.com>
Date: Thu, 2 Jan 2025 09:49:45 +0100
From: Milan Broz <gmazyland@...il.com>
To: Eric Biggers <ebiggers@...nel.org>, linux-crypto@...r.kernel.org
Cc: linux-kernel@...r.kernel.org, dm-devel@...ts.linux.dev,
 Atharva Tiwari <evepolonium@...il.com>, Shane Wang <shane.wang@...el.com>
Subject: Re: [PATCH] crypto: vmac - remove unused VMAC algorithm

On 12/26/24 8:43 PM, Eric Biggers wrote:
> From: Eric Biggers <ebiggers@...gle.com>
> 
> Remove the vmac64 template, as it has no known users.  It also continues
> to have longstanding bugs such as alignment violations (see
> https://lore.kernel.org/r/20241226134847.6690-1-evepolonium@gmail.com/).

...

> No in-tree user has appeared since then, other than potentially the
> usual components that allow specifying arbitrary hash algorithms by
> name, namely AF_ALG and dm-integrity.  However there are no indications
> that VMAC is being used with these components.  Debian Code Search and
> web searches for "vmac64" (the actual algorithm name) do not return any
> results other than the kernel itself, suggesting that it does not appear
> in any other code or documentation.  Explicitly grepping the source code
> of the usual suspects (libell, iwd, cryptsetup) finds no matches either.

AFAIK it was never used for dm-integrity / cryptsetup and I am not even able
to make it work for test now (isn't the vmac64 alg module init even broken?).

Just remove it...

Thanks,
Milan