linux-kernel - Re: [PATCH v15 10/13] tsc: Upgrade TSC clocksource rating

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250102093237.GEZ3ZdNa-zuiyC9LUQ@fat_crate.local>
Date: Thu, 2 Jan 2025 10:32:37 +0100
From: Borislav Petkov <bp@...en8.de>
To: "Nikunj A. Dadhania" <nikunj@....com>
Cc: tglx@...utronix.de, linux-kernel@...r.kernel.org,
	thomas.lendacky@....com, x86@...nel.org, kvm@...r.kernel.org,
	mingo@...hat.com, dave.hansen@...ux.intel.com, pgonda@...gle.com,
	seanjc@...gle.com, pbonzini@...hat.com,
	Alexey Makhalov <alexey.makhalov@...adcom.com>,
	Juergen Gross <jgross@...e.com>,
	Boris Ostrovsky <boris.ostrovsky@...cle.com>
Subject: Re: [PATCH v15 10/13] tsc: Upgrade TSC clocksource rating

On Thu, Jan 02, 2025 at 10:50:53AM +0530, Nikunj A. Dadhania wrote:
> This is what was suggested by tglx: 
> 
> "So if you know you want TSC to be selected, then upgrade the rating of
>  both the early and the regular TSC clocksource and be done with it."

I highly doubt that he saw what you have now:

Your commit message is talking about virtualized environments but your diff is
doing a global, unconditional change which affects *everything*.

If we are going to do this, we need to put this at least through the
meatgrinder and run it on *everything* that's out there and see what falls out
before we make it the default.

But if tglx thinks this is fine, I won't object - I've uttered my scepticism
already.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette