linux-kernel - Re: [PATCH v2 4/4] platform/x86: Add Lenovo Other Mode WMI Driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202501021728.uZ2voPKr-lkp@intel.com>
Date: Thu, 2 Jan 2025 17:33:56 +0800
From: kernel test robot <lkp@...el.com>
To: "Derek J. Clark" <derekjohn.clark@...il.com>,
	Hans de Goede <hdegoede@...hat.com>,
	Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
Cc: oe-kbuild-all@...ts.linux.dev, Jonathan Corbet <corbet@....net>,
	Mario Limonciello <superm1@...nel.org>,
	Luke Jones <luke@...nes.dev>, Xino Ni <nijs1@...ovo.com>,
	Zhixin Zhang <zhangzx36@...ovo.com>, Mia Shao <shaohz1@...ovo.com>,
	Mark Pearson <mpearson-lenovo@...ebb.ca>,
	"Pierre-Loup A . Griffais" <pgriffais@...vesoftware.com>,
	"Cody T . -H . Chiu" <codyit@...il.com>,
	John Martens <johnfanv2@...il.com>,
	"Derek J . Clark" <derekjohn.clark@...il.com>,
	platform-driver-x86@...r.kernel.org, linux-doc@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 4/4] platform/x86: Add Lenovo Other Mode WMI Driver

Hi Derek,

kernel test robot noticed the following build errors:

[auto build test ERROR on amd-pstate/linux-next]
[also build test ERROR on amd-pstate/bleeding-edge linus/master v6.13-rc5 next-20241220]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Derek-J-Clark/platform-x86-Add-lenovo-wmi-drivers-Documentation/20250102-085149
base:   https://git.kernel.org/pub/scm/linux/kernel/git/superm1/linux.git linux-next
patch link:    https://lore.kernel.org/r/20250102004854.14874-5-derekjohn.clark%40gmail.com
patch subject: [PATCH v2 4/4] platform/x86: Add Lenovo Other Mode WMI Driver
config: i386-allmodconfig (https://download.01.org/0day-ci/archive/20250102/202501021728.uZ2voPKr-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250102/202501021728.uZ2voPKr-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202501021728.uZ2voPKr-lkp@intel.com/

All errors (new ones prefixed by >>):

   drivers/platform/x86/lenovo-wmi-other.c: In function 'other_method_fw_attr_add':
>> drivers/platform/x86/lenovo-wmi-other.c:288:64: error: implicit declaration of function 'MKDEV' [-Werror=implicit-function-declaration]
     288 |         priv->fw_attr_dev = device_create(fw_attr_class, NULL, MKDEV(0, 0),
         |                                                                ^~~~~
   cc1: some warnings being treated as errors


vim +/MKDEV +288 drivers/platform/x86/lenovo-wmi-other.c

   277	
   278	static int other_method_fw_attr_add(struct lenovo_wmi_om_priv *priv)
   279	{
   280		int err, i;
   281	
   282		err = fw_attributes_class_get(&fw_attr_class);
   283		if (err) {
   284			pr_err("Failed to get firmware_attributes_class: %u\n", err);
   285			return err;
   286		}
   287	
 > 288		priv->fw_attr_dev = device_create(fw_attr_class, NULL, MKDEV(0, 0),
   289						  NULL, "%s", FW_ATTR_FOLDER);
   290		if (IS_ERR(priv->fw_attr_dev)) {
   291			err = PTR_ERR(priv->fw_attr_dev);
   292			pr_err("Failed to create firmware_attributes_class device: %u\n",
   293			       err);
   294			goto fail_class_get;
   295		}
   296	
   297		priv->fw_attr_kset = kset_create_and_add("attributes", NULL,
   298							 &priv->fw_attr_dev->kobj);
   299		if (!priv->fw_attr_kset) {
   300			err = -ENOMEM;
   301			pr_err("Failed to create firmware_attributes_class kset: %u\n",
   302			       err);
   303			goto err_destroy_classdev;
   304		}
   305	
   306		for (i = 0; i < ARRAY_SIZE(capdata01_attr_groups) - 1; i++) {
   307			err = attr_capdata01_setup(
   308				capdata01_attr_groups[i].tunable_attr);
   309			if (err) {
   310				pr_err("Failed to populate capability data for %s: %u\n",
   311				       capdata01_attr_groups[i].attr_group->name, err);
   312				continue;
   313			}
   314	
   315			err = sysfs_create_group(&priv->fw_attr_kset->kobj,
   316						 capdata01_attr_groups[i].attr_group);
   317			if (err) {
   318				pr_err("Failed to create sysfs-group for %s: %u\n",
   319				       capdata01_attr_groups[i].attr_group->name, err);
   320				goto err_remove_groups;
   321			}
   322		}
   323	
   324		return 0;
   325	
   326	err_remove_groups:
   327		while (i-- > 0) {
   328			sysfs_remove_group(&priv->fw_attr_kset->kobj,
   329					   capdata01_attr_groups[i].attr_group);
   330		}
   331	
   332		return err;
   333	
   334	err_destroy_classdev:
   335		device_destroy(fw_attr_class, MKDEV(0, 0));
   336	
   337		return err;
   338	
   339	fail_class_get:
   340		fw_attributes_class_put();
   341	
   342		return err;
   343	}
   344	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki