linux-kernel - Re: [PATCH v7 1/4] x86/smp: Allow calling mwait_play

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f597da81-abdc-4133-b5ad-432792b6aa6e@linux.intel.com>
Date: Thu, 2 Jan 2025 10:50:26 +0100
From: Patryk Wlazlyn <patryk.wlazlyn@...ux.intel.com>
To: "Rafael J. Wysocki" <rafael@...nel.org>
Cc: x86@...nel.org, linux-kernel@...r.kernel.org, linux-pm@...r.kernel.org,
 rafael.j.wysocki@...el.com, peterz@...radead.org,
 dave.hansen@...ux.intel.com, gautham.shenoy@....com, tglx@...utronix.de,
 len.brown@...el.com, artem.bityutskiy@...ux.intel.com
Subject: Re: [PATCH v7 1/4] x86/smp: Allow calling mwait_play_dead with an
 arbitrary hint

>>> And honestly I'm wondering why adding a parameter to mwait_play_dead()
>>> is better than introducing mwait_play_dead_with_hint(), in analogy
>>> with the existing mwait_idle_with_hints()?

Well.. Maybe that wasn't that good of an idea. I've given the rationale
in the 0/4:

> Changes since v6:
>  * Renamed mwait_play_dead to mwait_play_dead_cpuid_hint in 1/1, so that
>    mwait_play_dead name can be reused for the function that takes the
>    MWAIT hint as an argument. This leaves the comments around the
>    smpboot.c file that reference the old mwait_play_dead() unchanged.

It makes the patches simpler, in a sense that I don't have to update the
comments each patch when moving things around and renaming.