linux-kernel - Re: [PATCH v3 7/8] i2c: riic: Use predefined macro and simplify clock tick calculation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+V-a8sivMvR8-2gBOBSRmoiY7Axwo2Lh+Y7tbEx2opem7yJGQ@mail.gmail.com>
Date: Thu, 2 Jan 2025 10:05:28 +0000
From: "Lad, Prabhakar" <prabhakar.csengg@...il.com>
To: Andy Shevchenko <andy.shevchenko@...il.com>
Cc: Chris Brandt <chris.brandt@...esas.com>, Andi Shyti <andi.shyti@...nel.org>, 
	Geert Uytterhoeven <geert+renesas@...der.be>, Wolfram Sang <wsa+renesas@...g-engineering.com>, 
	Philipp Zabel <p.zabel@...gutronix.de>, linux-renesas-soc@...r.kernel.org, 
	linux-i2c@...r.kernel.org, linux-kernel@...r.kernel.org, 
	Biju Das <biju.das.jz@...renesas.com>, 
	Fabrizio Castro <fabrizio.castro.jz@...esas.com>, 
	Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>, 
	Claudiu Beznea <claudiu.beznea.uj@...renesas.com>
Subject: Re: [PATCH v3 7/8] i2c: riic: Use predefined macro and simplify clock
 tick calculation

Hi Andy,

Thank you for the review.

On Sat, Dec 28, 2024 at 11:37 PM Andy Shevchenko
<andy.shevchenko@...il.com> wrote:
>
> Fri, Dec 27, 2024 at 11:51:53AM +0000, Prabhakar kirjoitti:
> > From: Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>
> >
> > Replace the hardcoded `1000000000` with the predefined `NANO` macro for
> > clarity. Simplify the code by introducing a `ns_per_tick` variable to
> > store `NANO / rate`, reducing redundancy and improving readability.
>
> ...
>
> > -     brl -= t->scl_fall_ns / (1000000000 / rate);
> > -     brh -= t->scl_rise_ns / (1000000000 / rate);
> > +     ns_per_tick = NANO / rate;
>
> So, why NANO and not NSEC_PER_SEC?
>
Agreed, I'll switch to NSEC_PER_SEC.

Cheers,
Prabhakar