linux-kernel - Re: [PATCH v3 4/6] dt-bindings: opp: Add v2-qcom-adreno vendor bindings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c16aeecd-8321-4df2-9db5-e9d5117200da@quicinc.com>
Date: Thu, 2 Jan 2025 15:58:49 +0530
From: Akhil P Oommen <quic_akhilpo@...cinc.com>
To: Konrad Dybcio <konradybcio@...il.com>,
        "Rob Herring (Arm)"
	<robh@...nel.org>
CC: Krzysztof Kozlowski <krzk+dt@...nel.org>, Nishanth Menon <nm@...com>,
        Conor Dooley <conor+dt@...nel.org>,
        Abhinav Kumar
	<quic_abhinavk@...cinc.com>,
        <devicetree@...r.kernel.org>,
        Marijn Suijten
	<marijn.suijten@...ainline.org>,
        Simona Vetter <simona@...ll.ch>, Sean Paul
	<sean@...rly.run>,
        <freedreno@...ts.freedesktop.org>,
        Bjorn Andersson
	<andersson@...nel.org>, <linux-pm@...r.kernel.org>,
        Dmitry Baryshkov
	<dmitry.baryshkov@...aro.org>,
        Viresh Kumar <vireshk@...nel.org>, <dri-devel@...ts.freedesktop.org>,
        <linux-arm-msm@...r.kernel.org>, "Stephen
 Boyd" <sboyd@...nel.org>,
        Rob Clark <robdclark@...il.com>, <linux-kernel@...r.kernel.org>,
        Konrad Dybcio <konradybcio@...nel.org>,
        "David Airlie" <airlied@...il.com>
Subject: Re: [PATCH v3 4/6] dt-bindings: opp: Add v2-qcom-adreno vendor
 bindings

On 12/31/2024 3:09 PM, Konrad Dybcio wrote:
> On 30.12.2024 11:25 PM, Rob Herring (Arm) wrote:
>>
>> On Tue, 31 Dec 2024 02:41:05 +0530, Akhil P Oommen wrote:
>>> Add a new schema which extends opp-v2 to support a new vendor specific
>>> property required for Adreno GPUs found in Qualcomm's SoCs. The new
>>> property called "qcom,opp-acd-level" carries a u32 value recommended
>>> for each opp needs to be shared to GMU during runtime.
>>>
>>> Also, update MAINTAINERS file include the new opp-v2-qcom-adreno.yaml.
>>>
>>> Cc: Rob Clark <robdclark@...il.com>
>>> Signed-off-by: Akhil P Oommen <quic_akhilpo@...cinc.com>
>>> ---
>>>  .../bindings/opp/opp-v2-qcom-adreno.yaml           | 97 ++++++++++++++++++++++
>>>  MAINTAINERS                                        |  1 +
>>>  2 files changed, 98 insertions(+)
>>>
>>
>> My bot found errors running 'make dt_binding_check' on your patch:
>>
>> yamllint warnings/errors:
>>
>> dtschema/dtc warnings/errors:
>> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/opp/opp-v2-qcom-adreno.yaml: ignoring, error parsing file
>> Traceback (most recent call last):
>>   File "/usr/bin/yamllint", line 33, in <module>
>>     sys.exit(load_entry_point('yamllint==1.29.0', 'console_scripts', 'yamllint')())
>>              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
>>   File "/usr/lib/python3/dist-packages/yamllint/cli.py", line 228, in run
>>     prob_level = show_problems(problems, file, args_format=args.format,
> 
> You need to shift the closing '}':
> 
> diff --git a/Documentation/devicetree/bindings/opp/opp-v2-qcom-adreno.yaml b/Documentation/devicetree/bindings/opp/opp-v2-qcom-adreno.yaml
> index b7874f43aaf6..46fbffaf0a61 100644
> --- a/Documentation/devicetree/bindings/opp/opp-v2-qcom-adreno.yaml
> +++ b/Documentation/devicetree/bindings/opp/opp-v2-qcom-adreno.yaml
> @@ -93,5 +93,4 @@ examples:
>              opp-peak-kBps = <2136719>;
>              /* Intentionally left out qcom,opp-acd-level property here */
>          };
> -
> -};
> +    };
> 

Thanks. Will update.

-Akhil

> 
> Konrad