linux-kernel - Re: [PATCH] arm64: dts: hisilicon: Remove unused and undocumented "enable-dma" property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <677677ED.7060902@hisilicon.com>
Date: Thu, 2 Jan 2025 19:26:37 +0800
From: Wei Xu <xuwei5@...ilicon.com>
To: "Rob Herring (Arm)" <robh@...nel.org>, Krzysztof Kozlowski
	<krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>
CC: <linux-arm-kernel@...ts.infradead.org>, <devicetree@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>, <xuwei5@...ilicon.com>
Subject: Re: [PATCH] arm64: dts: hisilicon: Remove unused and undocumented
 "enable-dma" property

Hi Rob,

On 2024/11/16 3:34, Rob Herring (Arm) wrote:
> Remove "enable-dma" property which is both unused in the kernel and
> undocumented. Most likely they are leftovers from downstream.
> 
> Signed-off-by: Rob Herring (Arm) <robh@...nel.org>
> ---
>  arch/arm64/boot/dts/hisilicon/hi6220.dtsi | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/hisilicon/hi6220.dtsi b/arch/arm64/boot/dts/hisilicon/hi6220.dtsi
> index a589954c29e2..12f621cedf89 100644
> --- a/arch/arm64/boot/dts/hisilicon/hi6220.dtsi
> +++ b/arch/arm64/boot/dts/hisilicon/hi6220.dtsi
> @@ -728,7 +728,6 @@ spi0: spi@...06000 {
>  			reg = <0x0 0xf7106000 0x0 0x1000>;
>  			interrupts = <0 50 4>;
>  			bus-id = <0>;
> -			enable-dma = <0>;
>  			clocks = <&sys_ctrl HI6220_SPI_CLK>, <&sys_ctrl HI6220_SPI_CLK>;
>  			clock-names = "sspclk", "apb_pclk";
>  			pinctrl-names = "default";
> 

Thanks!
Since the "enable-dma" and "bus-id" both are not used by the pl022 driver,
when applying this patch, I have removed the "bus-id" and changed the 
commit message as well.

The detail is as following:
https://github.com/hisilicon/linux-hisi/commit/4a45f8c502a8b8a836c3c932a18d538856097ac7

Best Regards,
Wei