linux-kernel - Re: [PATCH v3] mm: add build-time option for hotplug memory default online type

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3a2d03dd-ee70-43b4-8b05-1be948bd0997@redhat.com>
Date: Thu, 2 Jan 2025 12:35:48 +0100
From: David Hildenbrand <david@...hat.com>
To: Gregory Price <gourry@...rry.net>
Cc: linux-mm@...ck.org, linux-doc@...r.kernel.org,
 linux-kernel@...r.kernel.org, loongarch@...ts.linux.dev,
 kernel-team@...a.com, corbet@....net, osalvador@...e.de,
 akpm@...ux-foundation.org, chenhuacai@...nel.org, kernel@...0n.name,
 gregkh@...uxfoundation.org, rafael@...nel.org
Subject: Re: [PATCH v3] mm: add build-time option for hotplug memory default
 online type

On 22.12.24 06:03, Gregory Price wrote:
> On Sat, Dec 21, 2024 at 04:30:21PM +0100, David Hildenbrand wrote:
>>
>>> -config MEMORY_HOTPLUG_DEFAULT_ONLINE
>>> -	bool "Online the newly added memory blocks by default"
>>> -	depends on MEMORY_HOTPLUG
>>> +choice
>>> +	prompt "Memory Hotplug Default Online Type"
>>> +	default MHP_DEFAULT_ONLINE_TYPE_OFFLINE
>>>    	help
>>> +	  Default memory type for driver managed hotplug memory.
>>
>> We should call it "hotplugged memory" consistently, which it is from a pure
>> core-mm perspective ("add memory").
>>
>> "Driver managed" reminds too much about add_memory_driver_managed(), which
>> is only one case. Maybe just drop the "e.g., page tables" from the examples
>> below.
>>
> 
> I suppose it's accurate that this also affects VM-hotplugged memory,
> which may not necessarily be "driver managed" in that regard. So it's
> more accurate to just say "hotplugged memory" - although even that's not
> quite completely accurate according to the definition in the docs.
> 
> Either way, will change it to "hotplugged memory".

The "really correct" thing might be "hot-added memory blocks", because 
that's what it is from a Linux MM POV.

Not sure though, if that will be particularly easier to grasp for end users.

-- 
Cheers,

David / dhildenb