linux-kernel - Re: [PATCH] netfilter: uapi: Merge xt_*.h/c and ipt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250102122315.GA3344@breakpoint.cc>
Date: Thu, 2 Jan 2025 13:23:15 +0100
From: Florian Westphal <fw@...len.de>
To: David Laight <david.laight.linux@...il.com>
Cc: Florian Westphal <fw@...len.de>, egyszeregy@...email.hu,
	pablo@...filter.org, lorenzo@...nel.org, daniel@...earbox.net,
	leitao@...ian.org, amiculas@...co.com, kadlec@...filter.org,
	davem@...emloft.net, dsahern@...nel.org, edumazet@...gle.com,
	kuba@...nel.org, pabeni@...hat.com, horms@...nel.org,
	netfilter-devel@...r.kernel.org, coreteam@...filter.org,
	linux-kernel@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCH] netfilter: uapi: Merge xt_*.h/c and ipt_*.h which has
 same name.

David Laight <david.laight.linux@...il.com> wrote:
> On Wed, 1 Jan 2025 23:46:44 +0100
> Florian Westphal <fw@...len.de> wrote:
> 
> > egyszeregy@...email.hu <egyszeregy@...email.hu> wrote:
> > >  /* match info */
> > > -struct xt_dscp_info {
> > > +struct xt_dscp_match_info {  
> > 
> > To add to what Jan already pointed out, such renames
> > break UAPI, please don't do this.
> 
> Doesn't the header file rename also break UAPI?

Sure, thats what Jan already pointed out, plus a suggestion
on how to do this correctly.