linux-kernel - Re: [PATCH 1/1] tools: fix atomic_set() definition to set the value correctly

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <9c5a1f67-728b-48c8-b124-280078486a31@lucifer.local>
Date: Thu, 2 Jan 2025 14:12:24 +0000
From: Lorenzo Stoakes <lorenzo.stoakes@...cle.com>
To: Suren Baghdasaryan <surenb@...gle.com>
Cc: akpm@...ux-foundation.org, liam.howlett@...cle.com, vbabka@...e.cz,
        jannh@...gle.com, linux-kernel@...r.kernel.org, linux-mm@...ck.org
Subject: Re: [PATCH 1/1] tools: fix atomic_set() definition to set the value
 correctly

On Fri, Dec 27, 2024 at 02:22:20PM -0800, Suren Baghdasaryan wrote:
> Currently vma test is failing because of the new vma_assert_attached()
> assertion. The check is failing because previous refcount_set() inside
> vma_mark_attached() is a NoOp. Fix the definition of atomic_set() to
> correctly set the value of the atomic.
>
> Fixes: 9325b8b5a1cb ("tools: add skeleton code for userland testing of VMA logic")
> Signed-off-by: Suren Baghdasaryan <surenb@...gle.com>

LGTM:

Reviewed-by: Lorenzo Stoakes <lorenzo.stoakes@...cle.com>

> ---
> Applies over mm-unstable
>
>  tools/testing/shared/linux/maple_tree.h | 2 +-
>  tools/testing/vma/linux/atomic.h        | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tools/testing/shared/linux/maple_tree.h b/tools/testing/shared/linux/maple_tree.h
> index 06c89bdcc515..f67d47d32857 100644
> --- a/tools/testing/shared/linux/maple_tree.h
> +++ b/tools/testing/shared/linux/maple_tree.h
> @@ -2,6 +2,6 @@
>  #define atomic_t int32_t
>  #define atomic_inc(x) uatomic_inc(x)
>  #define atomic_read(x) uatomic_read(x)
> -#define atomic_set(x, y) do {} while (0)
> +#define atomic_set(x, y) uatomic_set(x, y)
>  #define U8_MAX UCHAR_MAX
>  #include "../../../../include/linux/maple_tree.h"
> diff --git a/tools/testing/vma/linux/atomic.h b/tools/testing/vma/linux/atomic.h
> index 2e2021553196..788c597c4fde 100644
> --- a/tools/testing/vma/linux/atomic.h
> +++ b/tools/testing/vma/linux/atomic.h
> @@ -6,7 +6,7 @@
>  #define atomic_t int32_t
>  #define atomic_inc(x) uatomic_inc(x)
>  #define atomic_read(x) uatomic_read(x)
> -#define atomic_set(x, y) do {} while (0)
> +#define atomic_set(x, y) uatomic_set(x, y)
>  #define U8_MAX UCHAR_MAX
>
>  #ifndef atomic_cmpxchg_relaxed
> --
> 2.47.1.613.gc27f4b7a9f-goog
>