linux-kernel - Re: [PATCH v4 0/2] KVM: SVM: Make VMGEXIT GHCB exit codes more readable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <84f5e0b9-655a-9503-1781-26c31cb062eb@amd.com>
Date: Thu, 2 Jan 2025 08:58:01 -0600
From: Tom Lendacky <thomas.lendacky@....com>
To: Melody Wang <huibo.wang@....com>, Sean Christopherson <seanjc@...gle.com>
Cc: Paolo Bonzini <pbonzini@...hat.com>, KVM <kvm@...r.kernel.org>,
 LKML <linux-kernel@...r.kernel.org>, Dhaval Giani <dhaval.giani@....com>
Subject: Re: [PATCH v4 0/2] KVM: SVM: Make VMGEXIT GHCB exit codes more
 readable

On 12/30/24 14:36, Melody Wang wrote:

Just some FYIs when it comes to cover letters.

> Hi all,

No need to put this in a cover letter.

> 
> This patchset addresses all of review comments from Sean. All feedback is appreciated.

This should be part of your change log below.

Here you should have a summary of what the series is about.

> 
> Thanks,
> Melody
> 
> Changelog:
> v3:

You're missing the changes from v3 to v4 and you shouldn't delete the
previous log of changes from v1 to v2 and v2 to v3.

> 
> Here are two patches to make VMGEXIT GHCB exit codes more readable. All
> feedback is appreciated.

This should be at the top. Also, this isn't for exit codes, it is for the
hypervisor return error codes, right?

Thanks,
Tom

> 
> Melody Wang (2):
>   KVM: SVM: Convert plain error code numbers to defines
>   KVM: SVM: Provide helpers to set the error code
> 
>  arch/x86/include/asm/sev-common.h |  8 +++++++
>  arch/x86/kvm/svm/sev.c            | 36 ++++++++++++++++---------------
>  arch/x86/kvm/svm/svm.c            |  6 +-----
>  arch/x86/kvm/svm/svm.h            | 29 +++++++++++++++++++++++++
>  4 files changed, 57 insertions(+), 22 deletions(-)
>