linux-kernel - Re: [PATCH v2 2/4] dt-bindings: power: supply: add max77759-fg flavor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <cf75f897-1c00-4a37-bce3-f1eb9855a3cd@kernel.org>
Date: Thu, 2 Jan 2025 17:08:46 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: t.antoine@...ouvain.be, Sebastian Reichel <sre@...nel.org>,
 Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>, Dimitri Fedrau <dima.fedrau@...il.com>,
 Catalin Marinas <catalin.marinas@....com>, Will Deacon <will@...nel.org>,
 Peter Griffin <peter.griffin@...aro.org>,
 Alim Akhtar <alim.akhtar@...sung.com>,
 André Draszik <andre.draszik@...aro.org>
Cc: linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org,
 devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
 linux-samsung-soc@...r.kernel.org
Subject: Re: [PATCH v2 2/4] dt-bindings: power: supply: add max77759-fg flavor

On 02/01/2025 12:15, Thomas Antoine via B4 Relay wrote:
> From: Thomas Antoine <t.antoine@...ouvain.be>
> 
> The max77759 is an IC used to manage the power supply of the battery and

Still not the name I asked to use.

> the USB-C. Based on drivers from google, it contains at least a PMIC, a
> fuel gauge, a TCPCI and a charger.
> 
> Use max77759-fg compatible to avoid conflict with drivers for other
> functions.
> 
> The max77759 has no non-volatile memory so it doesn't require an address
> and instead requires a value for the current sensing resistor.
> 
> Signed-off-by: Thomas Antoine <t.antoine@...ouvain.be>
> ---
>  .../bindings/power/supply/maxim,max17201.yaml      | 56 +++++++++++++++++-----
>  1 file changed, 43 insertions(+), 13 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/power/supply/maxim,max17201.yaml b/Documentation/devicetree/bindings/power/supply/maxim,max17201.yaml
> index fe3dd9bd5585618e45220c51023391a5b21acfd2..7e95314508c27d0d90ea92f61bca6b4a2fe0e88e 100644
> --- a/Documentation/devicetree/bindings/power/supply/maxim,max17201.yaml
> +++ b/Documentation/devicetree/bindings/power/supply/maxim,max17201.yaml
> @@ -9,31 +9,61 @@ title: Maxim MAX17201 fuel gauge
>  maintainers:
>    - Dimitri Fedrau <dima.fedrau@...il.com>
>  
> -allOf:
> -  - $ref: power-supply.yaml#
> -
>  properties:
>    compatible:
>      oneOf:
>        - const: maxim,max17201
> +      - const: maxim,max77759-fg
>        - items:
>            - enum:
>                - maxim,max17205
>            - const: maxim,max17201
>  
> -  reg:
> -    items:
> -      - description: ModelGauge m5 registers
> -      - description: Nonvolatile registers

Widest constraints always stay here.

See:
https://elixir.bootlin.com/linux/v6.11-rc6/source/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml#L127

I did not say to remove it. I asked you to add allOf section restricting it.

> -
> -  reg-names:
> -    items:
> -      - const: m5
> -      - const: nvmem
> -
>    interrupts:
>      maxItems: 1
>  
> +allOf:

This goes after required: block. See example-schema.

> +  - $ref: power-supply.yaml#
> +  - if:
Best regards,
Krzysztof