linux-kernel - Re: [PATCH v4 04/15] mm: pgtable: add statistics for P4D level page table

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <237a3bf6-c24f-4feb-8d3d-bb3beb2fd18e@arm.com>
Date: Thu, 2 Jan 2025 17:53:52 +0100
From: Kevin Brodsky <kevin.brodsky@....com>
To: Qi Zheng <zhengqi.arch@...edance.com>, peterz@...radead.org,
 agordeev@...ux.ibm.com, palmer@...belt.com, tglx@...utronix.de,
 david@...hat.com, jannh@...gle.com, hughd@...gle.com, yuzhao@...gle.com,
 willy@...radead.org, muchun.song@...ux.dev, vbabka@...nel.org,
 lorenzo.stoakes@...cle.com, akpm@...ux-foundation.org, rientjes@...gle.com,
 vishal.moola@...il.com, arnd@...db.de, will@...nel.org,
 aneesh.kumar@...nel.org, npiggin@...il.com, dave.hansen@...ux.intel.com,
 rppt@...nel.org, ryan.roberts@....com
Cc: linux-mm@...ck.org, linux-arm-kernel@...ts.infradead.org,
 linuxppc-dev@...ts.ozlabs.org, linux-riscv@...ts.infradead.org,
 linux-s390@...r.kernel.org, sparclinux@...r.kernel.org,
 linux-kernel@...r.kernel.org, x86@...nel.org, linux-arch@...r.kernel.org,
 linux-csky@...r.kernel.org, linux-hexagon@...r.kernel.org,
 loongarch@...ts.linux.dev, linux-m68k@...ts.linux-m68k.org,
 linux-mips@...r.kernel.org, linux-openrisc@...r.kernel.org,
 linux-sh@...r.kernel.org, linux-um@...ts.infradead.org
Subject: Re: [PATCH v4 04/15] mm: pgtable: add statistics for P4D level page
 table

On 30/12/2024 10:07, Qi Zheng wrote:
> diff --git a/arch/riscv/include/asm/pgalloc.h b/arch/riscv/include/asm/pgalloc.h
> index 551d614d3369c..3466fbe2e508d 100644
> --- a/arch/riscv/include/asm/pgalloc.h
> +++ b/arch/riscv/include/asm/pgalloc.h
> @@ -108,8 +108,12 @@ static inline void __pud_free_tlb(struct mmu_gather *tlb, pud_t *pud,
>  static inline void __p4d_free_tlb(struct mmu_gather *tlb, p4d_t *p4d,
>  				  unsigned long addr)
>  {
> -	if (pgtable_l5_enabled)
> +	if (pgtable_l5_enabled) {
> +		struct ptdesc *ptdesc = virt_to_ptdesc(p4d);
> +
> +		pagetable_p4d_dtor(ptdesc);
>  		riscv_tlb_remove_ptdesc(tlb, virt_to_ptdesc(p4d));

Nit: could use the new ptdesc variable here instead of calling
virt_to_ptdesc().

- Kevin