linux-kernel - Re: [PATCH v4 4/5] dt-bindings: memory-controllers: Add support for Versal NET EDAC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <adca2723-611e-4b7a-9921-84af6596745d@kernel.org>
Date: Thu, 2 Jan 2025 19:00:50 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Shubhrajyoti Datta <shubhrajyoti.datta@....com>,
 Rob Herring <robh@...nel.org>, Conor Dooley <conor+dt@...nel.org>,
 Borislav Petkov <bp@...en8.de>, Tony Luck <tony.luck@...el.com>,
 James Morse <james.morse@....com>, Mauro Carvalho Chehab
 <mchehab@...nel.org>, Robert Richter <rric@...nel.org>,
 linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
 linux-edac@...r.kernel.org
Cc: git@....com
Subject: Re: [PATCH v4 4/5] dt-bindings: memory-controllers: Add support for
 Versal NET EDAC

On 02/01/2025 18:44, Shubhrajyoti Datta wrote:
> +
> +maintainers:
> +  - Shubhrajyoti Datta <shubhrajyoti.datta@....com>
> +
> +description:
> +  The integrated DDR Memory Controllers (DDRMCs) support both DDR5 and LPDDR5
> +  compact and extended  memory interfaces. Versal NET DDR memory controller has an optional ECC support

Please wrap code according to coding style (checkpatch is not a coding
style description, but only a tool).


> +  which correct single bit ECC errors and detect double bit ECC errors.
> +  It also has support for reporting other errors like MMCM (Mixed-Mode Clock
> +  Manager) errors and General software errors.
> +
> +properties:
> +  compatible:
> +    const: amd,versal-net-ddrmc5-1.0

1.0 looks redundant. Usually SoC does not change... Anyway, commit msg
should explain why 1.0 is needed (IOW, why exception is justified).

> +
> +  amd,rproc:
> +    $ref: /schemas/types.yaml#/definitions/phandle
> +    description:
> +      phandle to the remoteproc_r5 rproc node using which APU interacts
> +      with remote processor. APU primarily communicates with the RPU for
> +      accessing the DDRMC address space and getting error notification.
> +
> +required:
> +  - compatible
> +  - amd,rproc
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    memory-controller {
> +       compatible = "amd,versalnet-ddrmc";

And this one?


Best regards,
Krzysztof