linux-kernel - Re: [PATCH 01/10] HID: pidff: Convert infinite length from Linux API to PID standard

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <OSZPR01MB8434C2B2997FBE6B0DD7E53298142@OSZPR01MB8434.jpnprd01.prod.outlook.com>
Date: Thu, 2 Jan 2025 12:37:15 +0800
From: Shengyu Qu <wiagn233@...look.com>
To: Tomasz Pakuła <tomasz.pakula.oficjalny@...il.com>,
 jikos@...nel.org, bentiss@...nel.org
Cc: linux-kernel@...r.kernel.org, linux-usb@...r.kernel.org,
 oleg@...arenk.ooo, paul@...cefreak18.xyz, f.kardame@...jaro.org,
 jules.noirant@...nge.fr
Subject: Re: [PATCH 01/10] HID: pidff: Convert infinite length from Linux API
 to PID standard

Hello,

在 2024/12/31 23:47, Tomasz Pakuła 写道:
> Linux defines 0 length as infinite in its force feedback API
> while USB PID defines NULL (0xffff). Most PID devices do not expect a
> 0-length effect and can't interpret it as infinite. This change fixes
> Force Feedback for most PID compliant devices.
>
> As most games depend on updating the values of already playing infinite
> effects, this is crucial to ensure they will actually work.
>
> Previously, users had to rely on third-party software to do this conversion
> and make their PID devices usable.
>
> Co-developed-by: Makarenko Oleg <oleg@...arenk.ooo>
> Signed-off-by: Makarenko Oleg <oleg@...arenk.ooo>
> Signed-off-by: Tomasz Pakuła <tomasz.pakula.oficjalny@...il.com>
> ---
>   drivers/hid/usbhid/hid-pidff.c | 7 ++++++-
>   1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/hid/usbhid/hid-pidff.c b/drivers/hid/usbhid/hid-pidff.c
> index 3b4ee21cd811..1b5d3db62c09 100644
> --- a/drivers/hid/usbhid/hid-pidff.c
> +++ b/drivers/hid/usbhid/hid-pidff.c
> @@ -301,7 +301,12 @@ static void pidff_set_effect_report(struct pidff_device *pidff,
>   		pidff->block_load[PID_EFFECT_BLOCK_INDEX].value[0];
>   	pidff->set_effect_type->value[0] =
>   		pidff->create_new_effect_type->value[0];
> -	pidff->set_effect[PID_DURATION].value[0] = effect->replay.length;
> +
> +	// Convert infinite lenght from Linux API (0)

Typo, lenght -> length


Best regards,

Shengyu

> +	// to PID standard (NULL) if needed
> +	pidff->set_effect[PID_DURATION].value[0] =
> +		effect->replay.length == 0 ? 0xffff : effect->replay.length;
> +
>   	pidff->set_effect[PID_TRIGGER_BUTTON].value[0] = effect->trigger.button;
>   	pidff->set_effect[PID_TRIGGER_REPEAT_INT].value[0] =
>   		effect->trigger.interval;