linux-kernel - Re: [PATCH v2 2/4] platform/x86: Add Lenovo GameZone WMI Driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e588aeeb-e4f3-4780-be0b-ee2e9aa51f6e@kernel.org>
Date: Thu, 2 Jan 2025 13:10:28 -0600
From: Mario Limonciello <superm1@...nel.org>
To: Derek John Clark <derekjohn.clark@...il.com>
Cc: Hans de Goede <hdegoede@...hat.com>,
 Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>,
 Jonathan Corbet <corbet@....net>, Luke Jones <luke@...nes.dev>,
 Xino Ni <nijs1@...ovo.com>, Zhixin Zhang <zhangzx36@...ovo.com>,
 Mia Shao <shaohz1@...ovo.com>, Mark Pearson <mpearson-lenovo@...ebb.ca>,
 "Pierre-Loup A . Griffais" <pgriffais@...vesoftware.com>,
 "Cody T . -H . Chiu" <codyit@...il.com>, John Martens <johnfanv2@...il.com>,
 platform-driver-x86@...r.kernel.org, linux-doc@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 2/4] platform/x86: Add Lenovo GameZone WMI Driver

> 
> Simple fix. lenovo-wmi.c or lenovo-wmi-common.c is preferred?
> 

I think let's wait and see what the discussion on 0/4 lands on.  From 
your most recent comments I'm personally leaning it's best that 
"everything" is linked together as part of a single kernel object that 
happens to have a modalias that can let it auto-load from any one of the 
drivers.

That would mean you can put the helpers "between" drivers of that kernel 
object in a -common.c and use them as needed.  You can also avoid stuff 
like IS_REACHABLE because it all comes together as part of the kernel 
object.  You instead would just check if bound.

But let's see Armin's thoughts before you start moving things around.