linux-kernel - Re: [PATCH v3 07/14] iommufd/viommu: Add iommufd_viommu_get_vdev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250102202955.GE5556@nvidia.com>
Date: Thu, 2 Jan 2025 16:29:55 -0400
From: Jason Gunthorpe <jgg@...dia.com>
To: Baolu Lu <baolu.lu@...ux.intel.com>
Cc: Nicolin Chen <nicolinc@...dia.com>, kevin.tian@...el.com,
	will@...nel.org, corbet@....net, joro@...tes.org,
	suravee.suthikulpanit@....com, robin.murphy@....com,
	dwmw2@...radead.org, shuah@...nel.org, linux-kernel@...r.kernel.org,
	iommu@...ts.linux.dev, linux-arm-kernel@...ts.infradead.org,
	linux-kselftest@...r.kernel.org, linux-doc@...r.kernel.org,
	eric.auger@...hat.com, jean-philippe@...aro.org, mdf@...nel.org,
	mshavit@...gle.com, shameerali.kolothum.thodi@...wei.com,
	smostafa@...gle.com, ddutile@...hat.com, yi.l.liu@...el.com,
	patches@...ts.linux.dev
Subject: Re: [PATCH v3 07/14] iommufd/viommu: Add iommufd_viommu_get_vdev_id
 helper

On Mon, Dec 23, 2024 at 10:28:32AM +0800, Baolu Lu wrote:

> However, considering page fault scenarios, which are self-contained but
> linked to a hardware page table (hwpt), introduces ambiguity. Hwpt can
> be created with or without a vIOMMU. This raises the question: should
> the page fault message always report the iommufd device ID, or should
> the reporting depend on whether the hwpt was created from a vIOMMU?

I think every single event record read from the FD needs to clearly
specify what its fields are.

Page fault need to clearly say it's field is a device ID.

Jason