linux-kernel - Re: [PATCH 5.4~6.6] MIPS: Probe toolchain support of -msym32

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.21.2501020550110.20821@angie.orcam.me.uk>
Date: Thu, 2 Jan 2025 06:07:45 +0000 (GMT)
From: "Maciej W. Rozycki" <macro@...am.me.uk>
To: WangYuli <wangyuli@...ontech.com>
cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>, sashal@...nel.org, 
    stable@...r.kernel.org, jiaxun.yang@...goat.com, 
    Thomas Bogendoerfer <tsbogend@...ha.franken.de>, 
    linux-mips@...r.kernel.org, linux-kernel@...r.kernel.org, 
    guanwentao@...ontech.com, baimingcong@...ontech.com, revy@...pin.org
Subject: Re: [PATCH 5.4~6.6] MIPS: Probe toolchain support of -msym32

On Tue, 24 Dec 2024, WangYuli wrote:

> From: Jiaxun Yang <jiaxun.yang@...goat.com>
> 
> [ Upstream commit 18ca63a2e23c5e170d2d7552b64b1f5ad019cd9b ]
> 
> msym32 is not supported by LLVM toolchain.
> Workaround by probe toolchain support of msym32 for KBUILD_SYM32
> feature.

 Doesn't this reintroduce the failure fixed with commit a79a404e6c22 
("MIPS: Fix CONFIG_CPU_DADDI_WORKAROUNDS `modules_install' regression")?

 If this call to `cc-option-yn' does need to be made here, then this whole 
stuff has to be wrapped into a `need-compiler' check, see the discussion: 
<https://lore.kernel.org/r/alpine.DEB.2.21.2307180025120.62448@angie.orcam.me.uk/> 
and the other patches in the series.

  Maciej