linux-kernel - Re: [PATCH 2/3] Input: ads7846 - fix up the pendown GPIO setup on Nokia 770

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACRpkdbfuQuTQ028=hZgRhOPiw5AbPLyoZTbRCbvNDQ-e8UajQ@mail.gmail.com>
Date: Thu, 2 Jan 2025 22:32:00 +0100
From: Linus Walleij <linus.walleij@...aro.org>
To: Aaro Koskinen <aaro.koskinen@....fi>
Cc: Dmitry Torokhov <dmitry.torokhov@...il.com>, Helge Deller <deller@....de>, 
	Janusz Krzysztofik <jmkrzyszt@...il.com>, Tony Lindgren <tony@...mide.com>, linux-fbdev@...r.kernel.org, 
	linux-omap@...r.kernel.org, linux-input@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/3] Input: ads7846 - fix up the pendown GPIO setup on
 Nokia 770

On Thu, Jan 2, 2025 at 7:20 PM Aaro Koskinen <aaro.koskinen@....fi> wrote:

> The GPIO is set up as an IRQ, so request it as non-exclusive. Otherwise the
> probe fails on Nokia 770 with:
>
>     ads7846 spi2.0: failed to request pendown GPIO
>     ads7846: probe of spi2.0 failed with error -16
>
> Also the polarity is wrong. Fix it.
>
> Fixes: 767d83361aaa ("Input: ads7846 - Convert to use software nodes")
> Signed-off-by: Aaro Koskinen <aaro.koskinen@....fi>

Reviewed-by: Linus Walleij <linus.walleij@...aro.org>

Yours,
Linus Walleij