linux-kernel - Re: [PATCH] drm/tests: helpers: Fix compile wrarning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <oukgrncfkmq27ocpdjmp7kfvlm7rtu4czhxjzfsltemxyfoxtj@lhkaewyzjtev>
Date: Sat, 4 Jan 2025 00:16:42 +0200
From: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
To: Kuan-Wei Chiu <visitorckw@...il.com>
Cc: Yu-Chun Lin <eleanor15x@...il.com>, maarten.lankhorst@...ux.intel.com, 
	mripard@...nel.org, tzimmermann@...e.de, airlied@...il.com, simona@...ll.ch, 
	ruanjinjie@...wei.com, jserv@...s.ncku.edu.tw, dri-devel@...ts.freedesktop.org, 
	linux-kernel@...r.kernel.org, kernel test robot <lkp@...el.com>
Subject: Re: [PATCH] drm/tests: helpers: Fix compile wrarning

On Sat, Jan 04, 2025 at 05:43:54AM +0800, Kuan-Wei Chiu wrote:
> Hi Dmitry,
> 
> On Fri, Jan 03, 2025 at 08:14:20PM +0200, Dmitry Baryshkov wrote:
> > On Sat, Jan 04, 2025 at 12:17:58AM +0800, Yu-Chun Lin wrote:
> > > Delete one line break to make the format correct, resolving the
> > > following warning during a W=1 build:
> > > 
> > > >> drivers/gpu/drm/tests/drm_kunit_helpers.c:324: warning: bad line: for a KUnit test
> > > 
> > > Reported-by: kernel test robot <lkp@...el.com>
> > > Closes: https://lore.kernel.org/oe-kbuild-all/202501032001.O6WY1VCW-lkp@intel.com/
> > > Reviewed-by: Kuan-Wei Chiu <visitorckw@...il.com>
> > 
> > Reviewed where?
> > 
> Yu-Chun is a newcomer looking to contribute to Linux and asked for my
> help. As suggested in the last section of [1], she asked me to review
> her patch privately before sending it to the public mailing list and
> include my Reviewed-by tag. This improves patch quality and reduces
> the maintainer's workload by minimizing potential issues.

Good, thanks for the explanation. It's perfectly fine, just wanted to be
sure that this is what actually happened.

> 
> Although I'm not a DRM developer, I have been contributing to Linux for
> some time and wanted to provide support.
> 
> [1]: Documentation/process/researcher-guidelines.rst
> 
> > > Tested-by: Kuan-Wei Chiu <visitorckw@...il.com>
> > > Signed-off-by: Yu-Chun Lin <eleanor15x@...il.com>
> > > ---
> > >  drivers/gpu/drm/tests/drm_kunit_helpers.c | 3 +--
> > >  1 file changed, 1 insertion(+), 2 deletions(-)
> > > 
> > 
> > Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
> >
> Thanks for your review!
> 
> Regards,
> Kuan-Wei

-- 
With best wishes
Dmitry