linux-kernel - Re: [PATCH v4 2/4] arm64: dts: morello: Add support for common functionalities

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAL_JsqJ9y92aHUYhD9_YX8GKvZC-GioWbMr+gjcQiMA_XQ0RaQ@mail.gmail.com>
Date: Fri, 3 Jan 2025 16:26:08 -0600
From: Rob Herring <robh@...nel.org>
To: Vincenzo Frascino <vincenzo.frascino@....com>
Cc: devicetree@...r.kernel.org, linux-kernel@...r.kernel.org, 
	linux-arm-kernel@...ts.infradead.org, 
	Linus Walleij <linus.walleij@...aro.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>, 
	Conor Dooley <conor+dt@...nel.org>, Liviu Dudau <liviu.dudau@....com>, 
	Sudeep Holla <sudeep.holla@....com>, Lorenzo Pieralisi <lpieralisi@...nel.org>, 
	Russell King <linux@...linux.org.uk>
Subject: Re: [PATCH v4 2/4] arm64: dts: morello: Add support for common functionalities

On Fri, Jan 3, 2025 at 12:16 PM Vincenzo Frascino
<vincenzo.frascino@....com> wrote:
>
> The Morello architecture is an experimental extension to Armv8.2-A,
> which extends the AArch64 state with the principles proposed in
> version 7 of the Capability Hardware Enhanced RISC Instructions
> (CHERI) ISA.
>
> The Morello Platform (soc) and the Fixed Virtual Platfom (fvp) share
> some functionalities that have conveniently been included in
> morello.dtsi to avoid duplication.

One more thing...

> +               i2c0: i2c@...f0000 {
> +                       compatible = "cdns,i2c-r1p14";
> +                       reg = <0x0 0x1c0f0000 0x0 0x1000>;
> +                       interrupts = <GIC_SPI 138 IRQ_TYPE_LEVEL_HIGH>;
> +                       clocks = <&dpu_aclk>;
> +
> +                       #address-cells = <1>;
> +                       #size-cells = <0>;
> +
> +                       status = "disabled";
> +
> +                       hdmi_tx: hdmi-transmitter@70 {
> +                               compatible = "nxp,tda998x";

It is odd that you add this node here, but don't enable i2c. If this
is shared with fvp, then enable i2c here. If it isn't, then move this
to the soc/sdb .dts.

I'd rather see the FVP dts now rather than later so we can review how
you split things. It's a little odd not being soc.dtsi and board.dts,
but that's fine I think.

> +                               reg = <0x70>;
> +                               video-ports = <0x234501>;
> +                               port {
> +                                       tda998x_0_input: endpoint {
> +                                               remote-endpoint = <&dp_pl0_out0>;
> +                                       };
> +                               };
> +                       };
> +               };