linux-kernel - Re: [PATCH v2 13/16] scripts/sorttable: Move code from sorttable.h into sorttable.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250103180243.53cc9e98@gandalf.local.home>
Date: Fri, 3 Jan 2025 18:02:43 -0500
From: Steven Rostedt <rostedt@...dmis.org>
To: linux-kernel@...r.kernel.org, linux-trace-kernel@...r.kernel.org,
 linux-kbuild@...r.kernel.org, bpf <bpf@...r.kernel.org>
Cc: Masami Hiramatsu <mhiramat@...nel.org>, Mark Rutland
 <mark.rutland@....com>, Mathieu Desnoyers <mathieu.desnoyers@...icios.com>,
 Andrew Morton <akpm@...ux-foundation.org>, Peter Zijlstra
 <peterz@...radead.org>, Linus Torvalds <torvalds@...ux-foundation.org>,
 Masahiro Yamada <masahiroy@...nel.org>, Nathan Chancellor
 <nathan@...nel.org>, Nicolas Schier <nicolas@...sle.eu>, Zheng Yejian
 <zhengyejian1@...wei.com>, Martin  Kelly <martin.kelly@...wdstrike.com>,
 Christophe Leroy <christophe.leroy@...roup.eu>, Josh Poimboeuf
 <jpoimboe@...hat.com>
Subject: Re: [PATCH v2 13/16] scripts/sorttable: Move code from sorttable.h
 into sorttable.c

On Thu, 02 Jan 2025 18:26:22 -0500
Steven Rostedt <rostedt@...dmis.org> wrote:

> diff --git a/scripts/sorttable.c b/scripts/sorttable.c
> index 20615de18276..da9e1a82e886 100644
> --- a/scripts/sorttable.c
> +++ b/scripts/sorttable.c
> @@ -327,10 +327,420 @@ static inline void *get_index(void *start, int entsize, int index)
>  	return start + (entsize * index);
>  }
>  
> -/* 32 bit and 64 bit are very similar */
> -#include "sorttable.h"
> -#define SORTTABLE_64
> -#include "sorttable.h"
> +

[..]

> +
> +#if defined(SORTTABLE_64) && defined(UNWINDER_ORC_ENABLED)

My tests started to fail after this patch. It was the stack tracing tests
on x86_64. This patch removed the define of SORTTABLE_64, which stopped the
orc unwinder section from being sorted. :-p

Oops! When I post the stand-a-lone patches, this will be fixed.

-- Steve


> +/* ORC unwinder only support X86_64 */
> +#include <asm/orc_types.h>
> +
> +#define ERRSTR_MAXSZ	256
> +