linux-kernel - Re: [PATCH] ipmi: ssif_bmc: Move smbus

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <12ed4d01-9fe8-4d2b-af5a-fdb0ebe38bf1@os.amperecomputing.com>
Date: Fri, 3 Jan 2025 10:49:59 +0700
From: Quan Nguyen <quan@...amperecomputing.com>
To: corey@...yard.net, Cosmo Chou <chou.cosmo@...il.com>
Cc: minyard@....org, openipmi-developer@...ts.sourceforge.net,
 linux-kernel@...r.kernel.org, cosmo.chou@...ntatw.com, potin.lai@...ntatw.com
Subject: Re: [PATCH] ipmi: ssif_bmc: Move smbus_cmd assignment after cleanup



On 03/01/2025 10:20, Corey Minyard wrote:
> On Thu, Jan 02, 2025 at 12:54:31AM +0800, Cosmo Chou wrote:
>> Move smbus_cmd assignment to the end of process_smbus_cmd() to ensure
>> the new command is not lost when complete_response() is triggered.
> 
> Ok, I see, patch is applied.  Thank you.
> 
> Quan, I assume this is ok.  Please double-check it for me.
> 

Yes, Corey,

This patch looks good to me and I think this can be improved a bit 
further in my reply for Cosmo.

- Quan