linux-kernel - Re: [PATCH] i2c: amd756: Fix endianness handling for word data

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <eqjgc5a4fiz6csqmehyo66yduorxt3d3vnr62d5ijxy3wooheo@qabiaft2nri3>
Date: Sat, 4 Jan 2025 00:50:24 +0100
From: Andi Shyti <andi.shyti@...nel.org>
To: Wolfram Sang <wsa+renesas@...g-engineering.com>, 
	Atharva Tiwari <evepolonium@...il.com>, kernel test robot <lkp@...el.com>, 
	Jean Delvare <jdelvare@...e.com>, linux-i2c@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] i2c: amd756: Fix endianness handling for word data

On Sat, Jan 04, 2025 at 12:28:47AM +0100, Wolfram Sang wrote:
> > Now, you're treating it as a fix, which is perfectly fine. For
> > me, it's a 50-50 case.
> 
> For me, this is a clear no-fix case as long as nobody really reported
> problems (which I am not aware of). Also, looking at the Kconfig text,
> it looks unlikely to me that this controller has been used with big
> endian systems. Or?

Yeah! That was my first thought, but because this was reported
by LKP (which I respect more than other code analyzers) as a
potential issue, I was on the 50-50.

I still agree that the patch is correct because there's a
hanging comment. So, either remove the comment or go with
Athrva's approach.

Urgh, I'm just leaving things as they are :-)

Andi