linux-kernel - Re: [PATCH] cpufreq/amd-pstate: Fix prefcore rankings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4a0386d0-24f1-4b13-9111-6e4ea34083cd@amd.com>
Date: Fri, 3 Jan 2025 10:21:20 +0530
From: Dhananjay Ugwekar <Dhananjay.Ugwekar@....com>
To: Mario Limonciello <superm1@...nel.org>,
 "Gautham R . Shenoy" <gautham.shenoy@....com>,
 Perry Yuan <perry.yuan@....com>
Cc: "open list:X86 ARCHITECTURE (32-BIT AND 64-BIT)"
 <linux-kernel@...r.kernel.org>,
 "open list:CPU FREQUENCY SCALING FRAMEWORK" <linux-pm@...r.kernel.org>,
 Mario Limonciello <mario.limonciello@....com>, Sebastian <sobrus@...il.com>
Subject: Re: [PATCH] cpufreq/amd-pstate: Fix prefcore rankings

On 1/2/2025 7:42 PM, Mario Limonciello wrote:
> From: Mario Limonciello <mario.limonciello@....com>
> 
> commit 50a062a76200 ("cpufreq/amd-pstate: Store the boost numerator as
> highest perf again") updated the value stored for highest perf to no longer
> store the highest perf value but instead the boost numerator.
> 
> This is a fixed value for systems with preferred cores and not appropriate
> for use ITMT rankings. Update the value used for ITMT rankings to be the
> preferred core ranking.

Looks good to me,

Reviewed-by: Dhananjay Ugwekar <dhananjay.ugwekar@....com>

Thanks,
Dhananjay

> 
> Reported-and-tested-by: Sebastian <sobrus@...il.com>
> Closes: https://bugzilla.kernel.org/show_bug.cgi?id=219640
> Fixes: 50a062a76200 ("cpufreq/amd-pstate: Store the boost numerator as highest perf again")
> Signed-off-by: Mario Limonciello <mario.limonciello@....com>
> ---
>  drivers/cpufreq/amd-pstate.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c
> index 66e5dfc711c0c..f6d04eb40af94 100644
> --- a/drivers/cpufreq/amd-pstate.c
> +++ b/drivers/cpufreq/amd-pstate.c
> @@ -802,7 +802,7 @@ static void amd_pstate_init_prefcore(struct amd_cpudata *cpudata)
>  	 * sched_set_itmt_support(true) has been called and it is valid to
>  	 * update them at any time after it has been called.
>  	 */
> -	sched_set_itmt_core_prio((int)READ_ONCE(cpudata->highest_perf), cpudata->cpu);
> +	sched_set_itmt_core_prio((int)READ_ONCE(cpudata->prefcore_ranking), cpudata->cpu);
>  
>  	schedule_work(&sched_prefcore_work);
>  }