linux-kernel - RE: [PATCH v2] Revert "scsi: ufs: core: Probe for EXT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID:
 <DM6PR04MB6575AB56382F9BB641FDECB8FC152@DM6PR04MB6575.namprd04.prod.outlook.com>
Date: Fri, 3 Jan 2025 07:45:13 +0000
From: Avri Altman <Avri.Altman@....com>
To: Bart Van Assche <bvanassche@....org>, "Martin K . Petersen"
	<martin.petersen@...cle.com>
CC: "linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, Can Guo
	<quic_cang@...cinc.com>, Asutosh Das <quic_asutoshd@...cinc.com>
Subject: RE: [PATCH v2] Revert "scsi: ufs: core: Probe for EXT_IID support"

> Hi Avri,
> 
> Although the patch itself looks fine to me, is the description accurate? "dead
> code" means code that is not executed. I think that the code removed by this
> patch gets executed?
Will fix.

> 
> > diff --git a/include/ufs/ufshci.h b/include/ufs/ufshci.h index
> > 27364c4a6ef9..155f0801e907 100644
> > --- a/include/ufs/ufshci.h
> > +++ b/include/ufs/ufshci.h
> > @@ -23,7 +23,7 @@ enum {
> >   /* UFSHCI Registers */
> >   enum {
> >       REG_CONTROLLER_CAPABILITIES             = 0x00,
> > -     REG_MCQCAP                              = 0x04,
> > +     REG_MCQCAP                              = 0x04,
> 
> Is this whitespace-only change really necessary?
I was using tab - will fix.

Thanks,
Avri

> 
> Thanks,
> 
> Bart.