linux-kernel - [PATCH v3] mtd: rawnand: davinci: Reduce polling interval in NAND_OP_WAITRDY

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20250103-patch-nand-poll-v3-1-c85ca7bc54bd@bootlin.com>
Date: Fri, 03 Jan 2025 09:13:49 +0100
From: Bastien Curutchet <bastien.curutchet@...tlin.com>
To: Miquel Raynal <miquel.raynal@...tlin.com>, 
 Richard Weinberger <richard@....at>, Vignesh Raghavendra <vigneshr@...com>
Cc: linux-mtd@...ts.infradead.org, linux-kernel@...r.kernel.org, 
 Thomas Petazzoni <thomas.petazzoni@...tlin.com>, 
 Herve Codina <herve.codina@...tlin.com>, 
 Bastien Curutchet <bastien.curutchet@...tlin.com>, 
 Christopher Cordahi <christophercordahi@...ometrics.ca>
Subject: [PATCH v3] mtd: rawnand: davinci: Reduce polling interval in
 NAND_OP_WAITRDY_INSTR

For each NAND_OP_WAITRDY_INSTR operation, the NANDFSR register is
polled only once every 100 us to check for the EMA_WAIT pin. This
isn't frequent enough and causes delays in NAND accesses.

Set the polling interval to 5 us. It increases the page read speed
reported by flash_speed by ~30% (~10% on page writes).

Signed-off-by: Bastien Curutchet <bastien.curutchet@...tlin.com>
---
Changes in v3:
- Set poll interval to 5 us (instead of 0).
- Link to v2: https://lore.kernel.org/r/20241219-patch-nand-poll-v2-1-cc80a1ee4e0f@bootlin.com

Changes in v2:
- Fix SOB.
- Link to v1: https://lore.kernel.org/r/20241219-patch-nand-poll-v1-1-605e5f15f24a@bootlin.com
---
 drivers/mtd/nand/raw/davinci_nand.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mtd/nand/raw/davinci_nand.c b/drivers/mtd/nand/raw/davinci_nand.c
index 1f8354acfb50b2f4d155cdfc03afcf2863539f66..1a6c3b02a2c503f89ed54d557c6d181b68ce0fc8 100644
--- a/drivers/mtd/nand/raw/davinci_nand.c
+++ b/drivers/mtd/nand/raw/davinci_nand.c
@@ -724,7 +724,7 @@ static int davinci_nand_exec_instr(struct davinci_nand_info *info,
 	case NAND_OP_WAITRDY_INSTR:
 		timeout_us = instr->ctx.waitrdy.timeout_ms * 1000;
 		ret = readl_relaxed_poll_timeout(info->base + NANDFSR_OFFSET,
-						 status, status & BIT(0), 100,
+						 status, status & BIT(0), 5,
 						 timeout_us);
 		if (ret)
 			return ret;

---
base-commit: 40384c840ea1944d7c5a392e8975ed088ecf0b37
change-id: 20241219-patch-nand-poll-b215766ea0a2

Best regards,
-- 
Bastien Curutchet <bastien.curutchet@...tlin.com>