linux-kernel - Re: [PATCH v1 2/3] dt-bindings: soc: samsung: usi: add USIv1 and samsung,exynos8895-usi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <bzjuy4idp2o2cgms3zaftrxxz2rg2adhv6gneedrxjpxswgznn@wycin7xdlddz>
Date: Fri, 3 Jan 2025 09:21:08 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Ivaylo Ivanov <ivo.ivanov.ivanov1@...il.com>
Cc: Rob Herring <robh@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
	Alim Akhtar <alim.akhtar@...sung.com>, Sam Protsenko <semen.protsenko@...aro.org>, 
	devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, 
	linux-samsung-soc@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1 2/3] dt-bindings: soc: samsung: usi: add USIv1 and
 samsung,exynos8895-usi

On Thu, Jan 02, 2025 at 10:40:14PM +0200, Ivaylo Ivanov wrote:
> Add constants for choosing USIv1 configuration mode in device tree.
> Those are further used in the USI driver to figure out which value to
> write into SW_CONF register. Modify the current USI IP-core
> bindings to include information about USIv1 and a compatible for
> exynos8895.
> 
> Signed-off-by: Ivaylo Ivanov <ivo.ivanov.ivanov1@...il.com>
> ---
>  .../bindings/soc/samsung/exynos-usi.yaml      | 22 ++++++++++++++-----
>  include/dt-bindings/soc/samsung,exynos-usi.h  |  8 +++++++
>  2 files changed, 25 insertions(+), 5 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/soc/samsung/exynos-usi.yaml b/Documentation/devicetree/bindings/soc/samsung/exynos-usi.yaml
> index f80fcbc31..50db63a8a 100644
> --- a/Documentation/devicetree/bindings/soc/samsung/exynos-usi.yaml
> +++ b/Documentation/devicetree/bindings/soc/samsung/exynos-usi.yaml
> @@ -11,11 +11,21 @@ maintainers:
>    - Krzysztof Kozlowski <krzk@...nel.org>
>  
>  description: |
> -  USI IP-core provides selectable serial protocol (UART, SPI or High-Speed I2C).
> -  USI shares almost all internal circuits within each protocol, so only one
> -  protocol can be chosen at a time. USI is modeled as a node with zero or more
> -  child nodes, each representing a serial sub-node device. The mode setting
> -  selects which particular function will be used.
> +  The USI IP-core provides configurable support for serial protocols, enabling
> +  different serial communication modes depending on the version.
> +
> +  In USIv1, configurations are available to enable either one or two protocols
> +  simultaneously in select combinations - High-Speed I2C0, High-Speed
> +  I2C1, SPI, UART, High-Speed I2C0 and I2C1 or both High-Speed
> +  I2C1 and UART.
> +
> +  In USIv2, only one protocol can be active at a time, either UART, SPI, or
> +  High-Speed I2C.
> +
> +  The USI core shares internal circuits across protocols, meaning only the
> +  selected configuration is active at any given time. USI is modeled as a node
> +  with zero or more child nodes, each representing a serial sub-node device. The
> +  mode setting selects which particular function will be used.
>  
>  properties:
>    $nodename:
> @@ -31,6 +41,7 @@ properties:
>            - const: samsung,exynos850-usi
>        - enum:
>            - samsung,exynos850-usi
> +          - samsung,exynos8895-usi
>  
>    reg:
>      maxItems: 1
> @@ -106,6 +117,7 @@ if:
>        contains:
>          enum:
>            - samsung,exynos850-usi
> +          - samsung,exynos8895-usi
>  
>  then:
>    properties:
> diff --git a/include/dt-bindings/soc/samsung,exynos-usi.h b/include/dt-bindings/soc/samsung,exynos-usi.h
> index a01af169d..5fbeb426b 100644
> --- a/include/dt-bindings/soc/samsung,exynos-usi.h
> +++ b/include/dt-bindings/soc/samsung,exynos-usi.h
> @@ -9,6 +9,14 @@
>  #ifndef __DT_BINDINGS_SAMSUNG_EXYNOS_USI_H
>  #define __DT_BINDINGS_SAMSUNG_EXYNOS_USI_H
>  
> +#define USI_V1_NONE		0
> +#define USI_V1_I2C0		1
> +#define USI_V1_I2C1		2
> +#define USI_V1_I2C0_1		3
> +#define USI_V1_SPI		4
> +#define USI_V1_UART		5
> +#define USI_V1_UART_I2C1	6

Conflicting values with USI_v2. This is the same property and the same
driver, so I expect the values to be unified.

Rename (copy) USI_V2_ to USI_ and then just add yours at the end.
Binding then in allOf:if:then should restrict with enum which values
make sense for which model.

Best regards,
Krzysztof