linux-kernel - Re: [PATCH] net: ethernet: toshiba: ps3_gelic_wireless: Remove driver using deprecated API wext

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMuHMdVGdpVqkdvoFxu84YgBh_0fsAKeBhWFEg+nDyGLwbruig@mail.gmail.com>
Date: Fri, 3 Jan 2025 09:53:27 +0100
From: Geert Uytterhoeven <geert@...ux-m68k.org>
To: Philipp Hortmann <philipp.g.hortmann@...il.com>
Cc: Johannes Berg <johannes@...solutions.net>, Andrew Lunn <andrew+netdev@...n.ch>, 
	"David S . Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, 
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Geoff Levand <geoff@...radead.org>, 
	Simon Horman <horms@...nel.org>, Alexander Lobakin <aleksander.lobakin@...el.com>, netdev@...r.kernel.org, 
	linux-kernel@...r.kernel.org, Kalle Valo <kvalo@...nel.org>, 
	Alexandre Belloni <alexandre.belloni@...tlin.com>, Claudiu Beznea <claudiu.beznea@...on.dev>, 
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Jeff Johnson <quic_jjohnson@...cinc.com>, 
	Larry Finger <Larry.Finger@...inger.net>, Nicolas Ferre <nicolas.ferre@...rochip.com>, 
	Pavel Machek <pavel@....cz>, Stanislaw Gruszka <stf_xl@...pl>, 
	Gregory Greenman <gregory.greenman@...el.com>, linuxppc-dev <linuxppc-dev@...ts.ozlabs.org>, 
	linux-staging@...ts.linux.dev, linux-wireless@...r.kernel.org, 
	Arnd Bergmann <arnd@...db.de>, Stefan Lippers-Hollmann <s.l-h@....de>, Christoph Hellwig <hch@....de>
Subject: Re: [PATCH] net: ethernet: toshiba: ps3_gelic_wireless: Remove driver
 using deprecated API wext

Hi Philipp,

CC hch

On Fri, Jan 3, 2025 at 7:44 AM Philipp Hortmann
<philipp.g.hortmann@...il.com> wrote:
> T2 is working but to make this happen the T2 Author has an own repo for
> patches to apply. In the following video he publishes his view on how
> well the ps3disk is maintained and tested by the linux kernel community.
> My impression of this is that ps3disk is not tested on hardware at all.
> You can find this in a youtube video: “I can't believe VIP Linux kernel
> developer BROKE PS3 support” but watch out that you are in a good mood
> otherwise it is pulling you down like me...
>
> The commit that is breaking the function is:
> commit a7f18b74dbe171625afc2751942a92f71a4dd4ba

Thanks, I see no evidence of this ever being reported upstream, which
makes it rather difficult to be aware of the issue...

> This fixes are not in Mainline up to today. So who beside T2 Linux is
> using this? You can find more of those breaking patches... and videos...

Care to tell us where the fix is?

/me looks at the bad commit...

Oh, dev->bounce_size is used before set. Patch sent.
https://lore.kernel.org/06988f959ea6885b8bd7fb3b9059dd54bc6bbad7.1735894216.git.geert+renesas@glider.be

> The following points are also in the list of reasons:
> - This driver has a maximum 54MBit/s as it supports only 802.11 b/g.
> - Using this hardware is security wise not state of the art as WPA3 is
>    not supported.

If you only do VPN over such an insecure link, I guess it's still safe?

Gr{oetje,eeting}s,

                        Geert


--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds