linux-kernel - Re: [PATCH] ps3disk: Do not use dev->bounce

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250103085652.GA31691@lst.de>
Date: Fri, 3 Jan 2025 09:56:52 +0100
From: Christoph Hellwig <hch@....de>
To: Geert Uytterhoeven <geert+renesas@...der.be>
Cc: Christoph Hellwig <hch@....de>,
	Philipp Hortmann <philipp.g.hortmann@...il.com>,
	Geoff Levand <geoff@...radead.org>, Jens Axboe <axboe@...nel.dk>,
	linuxppc-dev@...ts.ozlabs.org, linux-block@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ps3disk: Do not use dev->bounce_size before it is set

On Fri, Jan 03, 2025 at 09:51:25AM +0100, Geert Uytterhoeven wrote:
> dev->bounce_size is only initialized after it is used to set the queue
> limits.  Fix this by using BOUNCE_SIZE instead.
> 
> Fixes: a7f18b74dbe17162 ("ps3disk: pass queue_limits to blk_mq_alloc_disk")
> Reported-by: Philipp Hortmann <philipp.g.hortmann@...il.com>
> Closes: https://lore.kernel.org/39256db9-3d73-4e86-a49b-300dfd670212@gmail.com
> Signed-off-by: Geert Uytterhoeven <geert+renesas@...der.be>

Looks fine:

Reviewed-by: Christoph Hellwig <hch@....de>

But looking at the report it seems like no one cares about ps3 upstream,
and in fact the only person caring at all rather rants on youtube than
helping upstream, so maybe we should just remove the ps3 support entirely?