linux-kernel - Re: [PATCH] tty: serial: fsl_lpuart: increase maximum uart

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2025010351-overlap-matchless-5c00@gregkh>
Date: Fri, 3 Jan 2025 10:08:26 +0100
From: Greg KH <gregkh@...uxfoundation.org>
To: Sherry Sun <sherry.sun@....com>
Cc: jirislaby@...nel.org, linux-serial@...r.kernel.org,
	linux-kernel@...r.kernel.org, imx@...ts.linux.dev
Subject: Re: [PATCH] tty: serial: fsl_lpuart: increase maximum uart_nr to 12

On Fri, Jan 03, 2025 at 03:11:54PM +0800, Sherry Sun wrote:
> Some SoCs like the i.MX943 have aliases for up to 12 UARTs, need to
> increase UART_NR from 8 to 12 to support lpuart9-12 to avoid
> initialization failures.
> 
> Signed-off-by: Sherry Sun <sherry.sun@....com>
> ---
>  drivers/tty/serial/fsl_lpuart.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/tty/serial/fsl_lpuart.c b/drivers/tty/serial/fsl_lpuart.c
> index 57b0632a3db6..7cb1e36fdaab 100644
> --- a/drivers/tty/serial/fsl_lpuart.c
> +++ b/drivers/tty/serial/fsl_lpuart.c
> @@ -245,7 +245,7 @@
>  
>  #define DRIVER_NAME	"fsl-lpuart"
>  #define DEV_NAME	"ttyLP"
> -#define UART_NR		8
> +#define UART_NR		12

Why not fix this properly and make this dynamic and get rid of the
static array causing all of this problem?  That way when you get a
system with 13 uarts, you will be ok :)

thanks,

greg k-h