linux-kernel - Re: [PATCH] PCI/AER:Add error message when unable to handle additional devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250103111732.00003ab3@huawei.com>
Date: Fri, 3 Jan 2025 11:17:32 +0000
From: Jonathan Cameron <Jonathan.Cameron@...wei.com>
To: Atharva Tiwari <evepolonium@...il.com>
CC: Mahesh J Salgaonkar <mahesh@...ux.ibm.com>, Oliver O'Halloran
	<oohall@...il.com>, Bjorn Helgaas <bhelgaas@...gle.com>,
	<linuxppc-dev@...ts.ozlabs.org>, <linux-pci@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] PCI/AER:Add error message when unable to handle
 additional devices

On Fri, 27 Dec 2024 12:49:10 +0530
Atharva Tiwari <evepolonium@...il.com> wrote:

> Log an error message in `find_device_iter'
> when the system cannot handle more error devices.
Needs a statement of 'why'

Jonathan

> 
> Signed-off-by: Atharva Tiwari <evepolonium@...il.com>
> ---
>  drivers/pci/pcie/aer.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/pci/pcie/aer.c b/drivers/pci/pcie/aer.c
> index 34ce9f834d0c..04743617202e 100644
> --- a/drivers/pci/pcie/aer.c
> +++ b/drivers/pci/pcie/aer.c
> @@ -886,7 +886,7 @@ static int find_device_iter(struct pci_dev *dev, void *data)
>  		/* List this device */
>  		if (add_error_device(e_info, dev)) {
>  			/* We cannot handle more... Stop iteration */
> -			/* TODO: Should print error message here? */
> +			pr_err("PCI: Unable to handle additional error devices\n");
>  			return 1;
>  		}
>