linux-kernel - Re: [PATCH v2 0/3] Take the scheduling domain into account in numa balancin

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250103113617.GE22934@noisy.programming.kicks-ass.net>
Date: Fri, 3 Jan 2025 12:36:17 +0100
From: Peter Zijlstra <peterz@...radead.org>
To: Chuyi Zhou <zhouchuyi@...edance.com>
Cc: mingo@...hat.com, juri.lelli@...hat.com, vincent.guittot@...aro.org,
	dietmar.eggemann@....com, rostedt@...dmis.org, bsegall@...gle.com,
	mgorman@...e.de, vschneid@...hat.com, longman@...hat.com,
	riel@...riel.com, chengming.zhou@...ux.dev, kprateek.nayak@....com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 0/3] Take the scheduling domain into account in numa
 balancin

On Fri, Jan 03, 2025 at 02:59:27PM +0800, Chuyi Zhou wrote:
> This patchset tries to adjust the logic of handling isolate cpus in numa balancing.
> 
> patch#1: Clean up for task_numa_migrate().
> 
> patch#2: Skips the isolate cpus when gathering numa status and finding
> idle cpus in update_numa_stats().
> 
> patch#3: Ensure that we do not select an isolated CPU in
> task_numa_find_cpu(), even if it is present in the task's CPU mask.

Your $subject and actual patches do not patch.

Your subject suggests you're taking the scheduling domains into account
for numa balancing, your actual patches are bunch of special case hacks
that totally ignore the actual sched domains :-(