linux-kernel - Re: [PATCH can-next v5 2/2] can: tcan4x5x: add option for selecting nWKRQ voltage

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <fndziki656cxg353f7bldt7s5dm2ybaq4e2foou3eb74savebx@q6uyltlj2klv>
Date: Fri, 3 Jan 2025 13:32:58 +0100
From: Sean Nyekjaer <sean@...nix.com>
To: Marc Kleine-Budde <mkl@...gutronix.de>
Cc: Vincent Mailhol <mailhol.vincent@...adoo.fr>, 
	"David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, 
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Rob Herring <robh@...nel.org>, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, linux-can@...r.kernel.org, 
	linux-kernel@...r.kernel.org, devicetree@...r.kernel.org
Subject: Re: [PATCH can-next v5 2/2] can: tcan4x5x: add option for selecting
 nWKRQ voltage

On Mon, Nov 18, 2024 at 04:14:09PM +0100, Marc Kleine-Budde wrote:
> On 18.11.2024 16:05:42, Sean Nyekjaer wrote:
> > Hi Marc,
> > 
> > On Thu, Nov 14, 2024 at 10:14:50AM +0100, Sean Nyekjaer wrote:
> > > The nWKRQ pin supports an output voltage of either the internal reference
> > > voltage (3.6V) or the reference voltage of
> > > the digital interface 0-6V (VIO).
> > > Add the devicetree option ti,nwkrq-voltage-vio to set it to VIO.
> > > 
> > > If this property is omitted the reset default, the internal reference
> > > voltage, is used.
> > > 
> > > Signed-off-by: Sean Nyekjaer <sean@...nix.com>
> > > Reviewed-by: Marc Kleine-Budde <mkl@...gutronix.de>
> > > Reviewed-by: Vincent Mailhol <mailhol.vincent@...adoo.fr>
> > > ---
> > >  drivers/net/can/m_can/tcan4x5x-core.c | 20 ++++++++++++++++++++
> > >  drivers/net/can/m_can/tcan4x5x.h      |  2 ++
> > >  2 files changed, 22 insertions(+)
> > > 
> > > diff --git a/drivers/net/can/m_can/tcan4x5x-core.c b/drivers/net/can/m_can/tcan4x5x-core.c
> > > index 2f73bf3abad889c222f15c39a3d43de1a1cf5fbb..7213d9894c82d079bf92f1ec62d4eebb500cdfa4 100644
> > > --- a/drivers/net/can/m_can/tcan4x5x-core.c
> > > +++ b/drivers/net/can/m_can/tcan4x5x-core.c
> > > @@ -92,6 +92,8 @@
> > >  #define TCAN4X5X_MODE_STANDBY BIT(6)
> > >  #define TCAN4X5X_MODE_NORMAL BIT(7)
> > >  
> > > +#define TCAN4X5X_NWKRQ_VOLTAGE_VIO BIT(19)
> > > +
> > >  #define TCAN4X5X_DISABLE_WAKE_MSK	(BIT(31) | BIT(30))
> > >  #define TCAN4X5X_DISABLE_INH_MSK	BIT(9)
> > >  
> > > @@ -267,6 +269,13 @@ static int tcan4x5x_init(struct m_can_classdev *cdev)
> > >  	if (ret)
> > >  		return ret;
> > >  
> > > +	if (tcan4x5x->nwkrq_voltage_vio) {
> > > +		ret = regmap_set_bits(tcan4x5x->regmap, TCAN4X5X_CONFIG,
> > > +				      TCAN4X5X_NWKRQ_VOLTAGE_VIO);
> > > +		if (ret)
> > > +			return ret;
> > > +	}
> > > +
> > >  	return ret;
> > >  }
> > >  
> > > @@ -318,6 +327,15 @@ static const struct tcan4x5x_version_info
> > >  	return &tcan4x5x_versions[TCAN4X5X];
> > >  }
> > >  
> > > +static void tcan4x5x_get_dt_data(struct m_can_classdev *cdev)
> > > +{
> > > +	struct tcan4x5x_priv *tcan4x5x = cdev_to_priv(cdev);
> > > +	struct device_node *np = cdev->dev->of_node;
> > 
> > Guess we can remove this line. Sorry
> 
> ACK. Will fixup here.

Remenber to do the fixup :)

Sorry for the extra work

/Sean