linux-kernel - Re: [PATCH 2/6] genksyms: fix memory leak when the same symbol is read from *.symref file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a7da70a4-19bf-4d53-a6c8-a5ddc422a199@web.de>
Date: Fri, 3 Jan 2025 13:50:06 +0100
From: Markus Elfring <Markus.Elfring@....de>
To: Masahiro Yamada <masahiroy@...nel.org>, linux-kbuild@...r.kernel.org
Cc: LKML <linux-kernel@...r.kernel.org>, Andreas Grünbacher
 <agruen@...e.de>, Andrew Morton <akpm@...ux-foundation.org>,
 Sam Ravnborg <sam@...nborg.org>
Subject: Re: [PATCH 2/6] genksyms: fix memory leak when the same symbol is
 read from *.symref file

…
> +++ b/scripts/genksyms/parse.y
> @@ -482,12 +482,12 @@ enumerator_list:
>  enumerator:
>  	IDENT
>  		{
> -			const char *name = strdup((*$1)->string);
> +			const char *name = (*$1)->string;
>  			add_symbol(name, SYM_ENUM_CONST, NULL, 0);
>  		}
…

I would find it safer and cleaner to separate such adjustments into another update step.
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.13-rc5#n81

Will code transformation concerns be reconsidered any more?

Regards,
Markus