| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <202501032214.HtGtSCgV-lkp@intel.com>
Date: Fri, 3 Jan 2025 22:54:09 +0800
From: kernel test robot <lkp@...el.com>
To: Vaibhav Agarwal <vaibhav.sr@...il.com>
Cc: oe-kbuild-all@...ts.linux.dev, linux-kernel@...r.kernel.org,
Dan Carpenter <error27@...il.com>
Subject: drivers/staging/greybus/audio_topology.c:1172:56: warning: '%s'
directive output may be truncated writing up to 31 bytes into a region of
size between 17 and 27
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 0bc21e701a6ffacfdde7f04f87d664d82e8a13bf
commit: c9a57eddb235d53b0a8b9d740e454ef466086fc8 staging: greybus: audio: Enable GB codec, audio module compilation.
date: 4 years, 5 months ago
config: parisc-randconfig-c44-20220907 (https://download.01.org/0day-ci/archive/20250103/202501032214.HtGtSCgV-lkp@intel.com/config)
compiler: hppa-linux-gcc (GCC) 12.4.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250103/202501032214.HtGtSCgV-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202501032214.HtGtSCgV-lkp@intel.com/
All warnings (new ones prefixed by >>):
drivers/staging/greybus/audio_topology.c: In function 'find_gb_module':
drivers/staging/greybus/audio_topology.c:31:21: warning: variable 'ret' set but not used [-Wunused-but-set-variable]
31 | int dev_id, ret;
| ^~~
drivers/staging/greybus/audio_topology.c: In function 'gbcodec_mixer_dapm_ctl_get':
drivers/staging/greybus/audio_topology.c:380:40: warning: variable 'info' set but not used [-Wunused-but-set-variable]
380 | struct gb_audio_ctl_elem_info *info;
| ^~~~
drivers/staging/greybus/audio_topology.c: In function 'gbaudio_tplg_process_kcontrols':
>> drivers/staging/greybus/audio_topology.c:1172:56: warning: '%s' directive output may be truncated writing up to 31 bytes into a region of size between 17 and 27 [-Wformat-truncation=]
1172 | snprintf(curr->name, NAME_SIZE, "GB %d %s", module->dev_id,
| ^~
1173 | temp_name);
| ~~~~~~~~~
drivers/staging/greybus/audio_topology.c:1172:17: note: 'snprintf' output between 6 and 47 bytes into a destination of size 32
1172 | snprintf(curr->name, NAME_SIZE, "GB %d %s", module->dev_id,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1173 | temp_name);
| ~~~~~~~~~~
drivers/staging/greybus/audio_topology.c: In function 'gbaudio_tplg_create_widget':
drivers/staging/greybus/audio_topology.c:1050:45: warning: '%s' directive output may be truncated writing up to 31 bytes into a region of size between 17 and 27 [-Wformat-truncation=]
1050 | snprintf(w->name, NAME_SIZE, "GB %d %s", module->dev_id, temp_name);
| ^~ ~~~~~~~~~
drivers/staging/greybus/audio_topology.c:1050:9: note: 'snprintf' output between 6 and 47 bytes into a destination of size 32
1050 | snprintf(w->name, NAME_SIZE, "GB %d %s", module->dev_id, temp_name);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
vim +1172 drivers/staging/greybus/audio_topology.c
6339d2322c47f4 Vaibhav Agarwal 2016-01-13 1137
6dd67645f22cfe Vaibhav Agarwal 2016-03-29 1138 static int gbaudio_tplg_process_kcontrols(struct gbaudio_module_info *module,
6339d2322c47f4 Vaibhav Agarwal 2016-01-13 1139 struct gb_audio_control *controls)
6339d2322c47f4 Vaibhav Agarwal 2016-01-13 1140 {
d4cd9daa49b2dc Vaibhav Agarwal 2016-07-05 1141 int i, csize, ret;
6339d2322c47f4 Vaibhav Agarwal 2016-01-13 1142 struct snd_kcontrol_new *dapm_kctls;
6339d2322c47f4 Vaibhav Agarwal 2016-01-13 1143 struct gb_audio_control *curr;
6339d2322c47f4 Vaibhav Agarwal 2016-01-13 1144 struct gbaudio_control *control, *_control;
6339d2322c47f4 Vaibhav Agarwal 2016-01-13 1145 size_t size;
6dd67645f22cfe Vaibhav Agarwal 2016-03-29 1146 char temp_name[NAME_SIZE];
6339d2322c47f4 Vaibhav Agarwal 2016-01-13 1147
6dd67645f22cfe Vaibhav Agarwal 2016-03-29 1148 size = sizeof(struct snd_kcontrol_new) * module->num_controls;
6dd67645f22cfe Vaibhav Agarwal 2016-03-29 1149 dapm_kctls = devm_kzalloc(module->dev, size, GFP_KERNEL);
6339d2322c47f4 Vaibhav Agarwal 2016-01-13 1150 if (!dapm_kctls)
6339d2322c47f4 Vaibhav Agarwal 2016-01-13 1151 return -ENOMEM;
6339d2322c47f4 Vaibhav Agarwal 2016-01-13 1152
6339d2322c47f4 Vaibhav Agarwal 2016-01-13 1153 curr = controls;
6dd67645f22cfe Vaibhav Agarwal 2016-03-29 1154 for (i = 0; i < module->num_controls; i++) {
6dd67645f22cfe Vaibhav Agarwal 2016-03-29 1155 ret = gbaudio_tplg_create_kcontrol(module, &dapm_kctls[i],
6339d2322c47f4 Vaibhav Agarwal 2016-01-13 1156 curr);
6339d2322c47f4 Vaibhav Agarwal 2016-01-13 1157 if (ret) {
6dd67645f22cfe Vaibhav Agarwal 2016-03-29 1158 dev_err(module->dev, "%s:%d type not supported\n",
6339d2322c47f4 Vaibhav Agarwal 2016-01-13 1159 curr->name, curr->iface);
6339d2322c47f4 Vaibhav Agarwal 2016-01-13 1160 goto error;
6339d2322c47f4 Vaibhav Agarwal 2016-01-13 1161 }
6dd67645f22cfe Vaibhav Agarwal 2016-03-29 1162 control = devm_kzalloc(module->dev, sizeof(struct
6339d2322c47f4 Vaibhav Agarwal 2016-01-13 1163 gbaudio_control),
6339d2322c47f4 Vaibhav Agarwal 2016-01-13 1164 GFP_KERNEL);
6339d2322c47f4 Vaibhav Agarwal 2016-01-13 1165 if (!control) {
6339d2322c47f4 Vaibhav Agarwal 2016-01-13 1166 ret = -ENOMEM;
6339d2322c47f4 Vaibhav Agarwal 2016-01-13 1167 goto error;
6339d2322c47f4 Vaibhav Agarwal 2016-01-13 1168 }
6339d2322c47f4 Vaibhav Agarwal 2016-01-13 1169 control->id = curr->id;
6dd67645f22cfe Vaibhav Agarwal 2016-03-29 1170 /* Prefix dev_id to widget_name */
6dd67645f22cfe Vaibhav Agarwal 2016-03-29 1171 strlcpy(temp_name, curr->name, NAME_SIZE);
6dd67645f22cfe Vaibhav Agarwal 2016-03-29 @1172 snprintf(curr->name, NAME_SIZE, "GB %d %s", module->dev_id,
6dd67645f22cfe Vaibhav Agarwal 2016-03-29 1173 temp_name);
6339d2322c47f4 Vaibhav Agarwal 2016-01-13 1174 control->name = curr->name;
e65579e335da0a Vaibhav Agarwal 2016-06-30 1175 if (curr->info.type == GB_AUDIO_CTL_ELEM_TYPE_ENUMERATED) {
e65579e335da0a Vaibhav Agarwal 2016-06-30 1176 struct gb_audio_enumerated *gbenum =
e65579e335da0a Vaibhav Agarwal 2016-06-30 1177 &curr->info.value.enumerated;
e65579e335da0a Vaibhav Agarwal 2016-06-30 1178
e65579e335da0a Vaibhav Agarwal 2016-06-30 1179 csize = offsetof(struct gb_audio_control, info);
e65579e335da0a Vaibhav Agarwal 2016-06-30 1180 csize += offsetof(struct gb_audio_ctl_elem_info, value);
e65579e335da0a Vaibhav Agarwal 2016-06-30 1181 csize += offsetof(struct gb_audio_enumerated, names);
055fb9ce92d59d Vaibhav Agarwal 2017-01-18 1182 csize += le16_to_cpu(gbenum->names_length);
6339d2322c47f4 Vaibhav Agarwal 2016-01-13 1183 control->texts = (const char * const *)
e65579e335da0a Vaibhav Agarwal 2016-06-30 1184 gb_generate_enum_strings(module, gbenum);
055fb9ce92d59d Vaibhav Agarwal 2017-01-18 1185 control->items = le32_to_cpu(gbenum->items);
02ae32f754a6cb Chase Metzger 2016-10-06 1186 } else {
d4cd9daa49b2dc Vaibhav Agarwal 2016-07-05 1187 csize = sizeof(struct gb_audio_control);
02ae32f754a6cb Chase Metzger 2016-10-06 1188 }
d4cd9daa49b2dc Vaibhav Agarwal 2016-07-05 1189
6dd67645f22cfe Vaibhav Agarwal 2016-03-29 1190 list_add(&control->list, &module->ctl_list);
6dd67645f22cfe Vaibhav Agarwal 2016-03-29 1191 dev_dbg(module->dev, "%d:%s created of type %d\n", curr->id,
6339d2322c47f4 Vaibhav Agarwal 2016-01-13 1192 curr->name, curr->info.type);
d4cd9daa49b2dc Vaibhav Agarwal 2016-07-05 1193 curr = (void *)curr + csize;
6339d2322c47f4 Vaibhav Agarwal 2016-01-13 1194 }
6dd67645f22cfe Vaibhav Agarwal 2016-03-29 1195 module->controls = dapm_kctls;
6339d2322c47f4 Vaibhav Agarwal 2016-01-13 1196
6339d2322c47f4 Vaibhav Agarwal 2016-01-13 1197 return 0;
6339d2322c47f4 Vaibhav Agarwal 2016-01-13 1198 error:
6dd67645f22cfe Vaibhav Agarwal 2016-03-29 1199 list_for_each_entry_safe(control, _control, &module->ctl_list,
6339d2322c47f4 Vaibhav Agarwal 2016-01-13 1200 list) {
6339d2322c47f4 Vaibhav Agarwal 2016-01-13 1201 list_del(&control->list);
6dd67645f22cfe Vaibhav Agarwal 2016-03-29 1202 devm_kfree(module->dev, control);
6339d2322c47f4 Vaibhav Agarwal 2016-01-13 1203 }
6dd67645f22cfe Vaibhav Agarwal 2016-03-29 1204 devm_kfree(module->dev, dapm_kctls);
6339d2322c47f4 Vaibhav Agarwal 2016-01-13 1205 return ret;
6339d2322c47f4 Vaibhav Agarwal 2016-01-13 1206 }
6339d2322c47f4 Vaibhav Agarwal 2016-01-13 1207
:::::: The code at line 1172 was first introduced by commit
:::::: 6dd67645f22cfeb55a32e9a08c92deb297d06935 greybus: audio: Use single codec driver registration
:::::: TO: Vaibhav Agarwal <vaibhav.agarwal@...aro.org>
:::::: CC: Greg Kroah-Hartman <gregkh@...gle.com>
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
Powered by blists - more mailing lists