Message-Id: <173591745953.2305360.498526194729700257.robh@kernel.org>
Date: Fri, 03 Jan 2025 09:20:33 -0600
From: "Rob Herring (Arm)" <robh@...nel.org>
To: J. Neuschäfer <j.ne@...teo.net>
Cc: Naveen N Rao <naveen@...nel.org>, linux-kernel@...r.kernel.org, 
 Madhavan Srinivasan <maddy@...ux.ibm.com>, 
 Christophe Leroy <christophe.leroy@...roup.eu>, 
 Conor Dooley <conor+dt@...nel.org>, 
 Linus Walleij <linus.walleij@...aro.org>, Frank Li <Frank.Li@....com>, 
 devicetree@...r.kernel.org, Krzysztof Kozlowski <krzk+dt@...nel.org>, 
 Bartosz Golaszewski <brgl@...ev.pl>, linuxppc-dev@...ts.ozlabs.org, 
 linux-gpio@...r.kernel.org, Nicholas Piggin <npiggin@...il.com>, 
 Michael Ellerman <mpe@...erman.id.au>
Subject: Re: [PATCH 00/19] powerpc: MPC83xx cleanup and LANCOM NWAPP2 board


On Thu, 02 Jan 2025 19:31:41 +0100, J. Neuschäfer wrote:
> This patchset adds a devicetree for the LANCOM NWAPP2 board based on the
> MPC8314E platform, and slightly modernizes the MPC83xx platform support
> in the process.
> 
> This board is nominally end-of-life, but available to hobbyists.
> A U-Boot port is also in the making.
> 
> Signed-off-by: J. Neuschäfer <j.ne@...teo.net>
> ---
> J. Neuschäfer (19):
>       powerpc: Generalize MPC831x platform support
>       powerpc: dts: Extract mpc8315e.dtsi from mpc8315erdb.dts
>       powerpc: dts: mpc8315e: Use IRQ_TYPE_* macros
>       powerpc: dts: mpc8315e: Add labels to peripherals
>       powerpc: dts: mpc8315e: Disable peripherals by default
>       powerpc: dts: mpc8315e: Add missing #cells properties to SPI bus
>       powerpc: dts: mpc8315erdb: Add missing model property
>       powerpc: boot: Enable FIT image generation
>       powerpc: boot: Build devicetrees when CONFIG_MPC831x=y
>       powerpc: dts: Add MPC8314E devicetree
>       dt-bindings: gpio: fsl,qoriq-gpio: Add compatible string fsl,mpc8314-gpio
>       powerpc: dts: mpc8315e: Add GPIO controller node
>       gpio: mpc8xxx: Add MPC8314 support
>       powerpc: mpc83xx: Switch to of_platform_populate
>       dt-bindings: vendor-prefixes: Add LANCOM Systems GmbH
>       powerpc: dts: Add LANCOM NWAPP2 board devicetree
>       powerpc: Regenerate mpc83xx_defconfig
>       powerpc: mpc83xx_defconfig: Enable NWAPP2 board features
>       MAINTAINERS: Add entry for LANCOM board support
> 
>  .../devicetree/bindings/gpio/fsl,qoriq-gpio.yaml   |   1 +
>  .../devicetree/bindings/vendor-prefixes.yaml       |   2 +
>  MAINTAINERS                                        |   8 +
>  arch/powerpc/Makefile                              |   3 +-
>  arch/powerpc/boot/Makefile                         |  11 +
>  arch/powerpc/boot/dts/Makefile                     |   6 +
>  arch/powerpc/boot/dts/lancom-nwapp2.dts            | 276 +++++++++++++++
>  arch/powerpc/boot/dts/mpc8314e.dtsi                |   7 +
>  arch/powerpc/boot/dts/mpc8315e.dtsi                | 390 +++++++++++++++++++++
>  arch/powerpc/boot/dts/mpc8315erdb.dts              | 327 +----------------
>  arch/powerpc/configs/83xx/mpc8313_rdb_defconfig    |   2 +-
>  arch/powerpc/configs/83xx/mpc8315_rdb_defconfig    |   2 +-
>  arch/powerpc/configs/mpc83xx_defconfig             |  41 ++-
>  arch/powerpc/configs/ppc6xx_defconfig              |   2 +-
>  arch/powerpc/platforms/83xx/Kconfig                |   6 +-
>  arch/powerpc/platforms/83xx/Makefile               |   2 +-
>  arch/powerpc/platforms/83xx/misc.c                 |   6 +-
>  .../platforms/83xx/{mpc831x_rdb.c => mpc831x.c}    |  21 +-
>  drivers/gpio/gpio-mpc8xxx.c                        |   1 +
>  19 files changed, 769 insertions(+), 345 deletions(-)
> ---
> base-commit: fc033cf25e612e840e545f8d5ad2edd6ba613ed5
> change-id: 20241231-mpc83xx-17c898a49441
> 
> Best regards,
> --
> J. Neuschäfer <j.ne@...teo.net>
> 
> 


My bot found new DTB warnings on the .dts files added or changed in this
series.

Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
are fixed by another series. Ultimately, it is up to the platform
maintainer whether these warnings are acceptable or not. No need to reply
unless the platform maintainer has comments.

If you already ran DT checks and didn't see these error(s), then
make sure dt-schema is up to date:

  pip3 install dtschema --upgrade


New warnings running 'make CHECK_DTBS=y lancom-nwapp2.dtb mpc8315erdb.dtb' for 20250102-mpc83xx-v1-0-86f78ba2a7af@...teo.net:

arch/powerpc/boot/dts/lancom-nwapp2.dtb: /: memory: False schema does not allow {'device_type': ['memory'], 'reg': [[0, 134217728]]}
	from schema $id: http://devicetree.org/schemas/root-node.yaml#
arch/powerpc/boot/dts/lancom-nwapp2.dtb: /: failed to match any schema with compatible: ['lancom,nwapp2', 'fsl,mpc8314e']
arch/powerpc/boot/dts/lancom-nwapp2.dtb: /: failed to match any schema with compatible: ['lancom,nwapp2', 'fsl,mpc8314e']
arch/powerpc/boot/dts/lancom-nwapp2.dtb: localbus@...05000: nand@0,0: 'ranges' is a required property
	from schema $id: http://devicetree.org/schemas/simple-bus.yaml#
arch/powerpc/boot/dts/lancom-nwapp2.dtb: /localbus@...05000: failed to match any schema with compatible: ['fsl,mpc8315-elbc', 'fsl,elbc', 'simple-bus']
arch/powerpc/boot/dts/lancom-nwapp2.dtb: /localbus@...05000: failed to match any schema with compatible: ['fsl,mpc8315-elbc', 'fsl,elbc', 'simple-bus']
arch/powerpc/boot/dts/lancom-nwapp2.dtb: /localbus@...05000/nand@0,0: failed to match any schema with compatible: ['fsl,mpc8315-fcm-nand', 'fsl,elbc-fcm-nand']
arch/powerpc/boot/dts/lancom-nwapp2.dtb: /localbus@...05000/nand@0,0: failed to match any schema with compatible: ['fsl,mpc8315-fcm-nand', 'fsl,elbc-fcm-nand']
arch/powerpc/boot/dts/lancom-nwapp2.dtb: immr@...00000: $nodename:0: 'immr@...00000' does not match '^([a-z][a-z0-9\-]+-bus|bus|localbus|soc|axi|ahb|apb)(@.+)?$'
	from schema $id: http://devicetree.org/schemas/simple-bus.yaml#
arch/powerpc/boot/dts/lancom-nwapp2.dtb: /immr@...00000: failed to match any schema with compatible: ['fsl,mpc8315-immr', 'simple-bus']
arch/powerpc/boot/dts/lancom-nwapp2.dtb: /immr@...00000/wdt@200: failed to match any schema with compatible: ['mpc83xx_wdt']
arch/powerpc/boot/dts/lancom-nwapp2.dtb: i2c@...0: compatible: 'oneOf' conditional failed, one must be fixed:
	['fsl-i2c'] is too short
	'fsl-i2c' is not one of ['mpc5200-i2c', 'fsl,mpc5200-i2c', 'fsl,mpc5121-i2c', 'fsl,mpc8313-i2c', 'fsl,mpc8543-i2c', 'fsl,mpc8544-i2c']
	'fsl,mpc5200b-i2c' was expected
	from schema $id: http://devicetree.org/schemas/i2c/i2c-mpc.yaml#
arch/powerpc/boot/dts/lancom-nwapp2.dtb: /immr@...00000/spi@...0: failed to match any schema with compatible: ['fsl,spi']
arch/powerpc/boot/dts/lancom-nwapp2.dtb: /immr@...00000/spi@...0/gpio-controller@0: failed to match any schema with compatible: ['onnn,74hc595a']
arch/powerpc/boot/dts/lancom-nwapp2.dtb: /immr@...00000/dma@...8: failed to match any schema with compatible: ['fsl,mpc8315-dma', 'fsl,elo-dma']
arch/powerpc/boot/dts/lancom-nwapp2.dtb: /immr@...00000/dma@...8: failed to match any schema with compatible: ['fsl,mpc8315-dma', 'fsl,elo-dma']
arch/powerpc/boot/dts/lancom-nwapp2.dtb: /immr@...00000/dma@...8/dma-channel@0: failed to match any schema with compatible: ['fsl,mpc8315-dma-channel', 'fsl,elo-dma-channel']
arch/powerpc/boot/dts/lancom-nwapp2.dtb: /immr@...00000/dma@...8/dma-channel@0: failed to match any schema with compatible: ['fsl,mpc8315-dma-channel', 'fsl,elo-dma-channel']
arch/powerpc/boot/dts/lancom-nwapp2.dtb: /immr@...00000/dma@...8/dma-channel@80: failed to match any schema with compatible: ['fsl,mpc8315-dma-channel', 'fsl,elo-dma-channel']
arch/powerpc/boot/dts/lancom-nwapp2.dtb: /immr@...00000/dma@...8/dma-channel@80: failed to match any schema with compatible: ['fsl,mpc8315-dma-channel', 'fsl,elo-dma-channel']
arch/powerpc/boot/dts/lancom-nwapp2.dtb: /immr@...00000/dma@...8/dma-channel@100: failed to match any schema with compatible: ['fsl,mpc8315-dma-channel', 'fsl,elo-dma-channel']
arch/powerpc/boot/dts/lancom-nwapp2.dtb: /immr@...00000/dma@...8/dma-channel@100: failed to match any schema with compatible: ['fsl,mpc8315-dma-channel', 'fsl,elo-dma-channel']
arch/powerpc/boot/dts/lancom-nwapp2.dtb: /immr@...00000/dma@...8/dma-channel@180: failed to match any schema with compatible: ['fsl,mpc8315-dma-channel', 'fsl,elo-dma-channel']
arch/powerpc/boot/dts/lancom-nwapp2.dtb: /immr@...00000/dma@...8/dma-channel@180: failed to match any schema with compatible: ['fsl,mpc8315-dma-channel', 'fsl,elo-dma-channel']
arch/powerpc/boot/dts/lancom-nwapp2.dtb: /immr@...00000/ethernet@...00: failed to match any schema with compatible: ['gianfar']
arch/powerpc/boot/dts/lancom-nwapp2.dtb: /immr@...00000/ethernet@...00/mdio@520: failed to match any schema with compatible: ['fsl,gianfar-mdio']
arch/powerpc/boot/dts/lancom-nwapp2.dtb: /immr@...00000/ethernet@...00: failed to match any schema with compatible: ['gianfar']
arch/powerpc/boot/dts/lancom-nwapp2.dtb: /immr@...00000/ethernet@...00/mdio@520: failed to match any schema with compatible: ['fsl,gianfar-tbi']
arch/powerpc/boot/dts/lancom-nwapp2.dtb: serial@...0: compatible: 'oneOf' conditional failed, one must be fixed:
	['fsl,ns16550', 'ns16550'] is too long
	['fsl,ns16550', 'ns16550'] is too short
	'ns8250' was expected
	'ns16450' was expected
	'ns16550' was expected
	'ns16550a' was expected
	'ns16850' was expected
	'aspeed,ast2400-vuart' was expected
	'aspeed,ast2500-vuart' was expected
	'intel,xscale-uart' was expected
	'mrvl,pxa-uart' was expected
	'nuvoton,wpcm450-uart' was expected
	'nuvoton,npcm750-uart' was expected
	'nvidia,tegra20-uart' was expected
	'nxp,lpc3220-uart' was expected
	'fsl,ns16550' is not one of ['exar,xr16l2552', 'exar,xr16l2551', 'exar,xr16l2550']
	'fsl,ns16550' is not one of ['ns16750', 'cavium,octeon-3860-uart', 'xlnx,xps-uart16550-2.00.b', 'ralink,rt2880-uart']
	'fsl,ns16550' is not one of ['nuvoton,npcm845-uart']
	'fsl,ns16550' is not one of ['ralink,mt7620a-uart', 'ralink,rt3052-uart', 'ralink,rt3883-uart']
	'fsl,ns16550' is not one of ['mediatek,mt7622-btif', 'mediatek,mt7623-btif']
	'mrvl,mmp-uart' was expected
	'fsl,ns16550' is not one of ['nvidia,tegra30-uart', 'nvidia,tegra114-uart', 'nvidia,tegra124-uart', 'nvidia,tegra210-uart', 'nvidia,tegra186-uart', 'nvidia,tegra194-uart', 'nvidia,tegra234-uart']
	'ralink,rt2880-uart' was expected
	'mediatek,mtk-btif' was expected
	from schema $id: http://devicetree.org/schemas/serial/8250.yaml#
arch/powerpc/boot/dts/lancom-nwapp2.dtb: serial@...0: Unevaluated properties are not allowed ('cell-index', 'compatible', 'device_type' were unexpected)
	from schema $id: http://devicetree.org/schemas/serial/8250.yaml#
arch/powerpc/boot/dts/lancom-nwapp2.dtb: serial@...0: compatible: 'oneOf' conditional failed, one must be fixed:
	['fsl,ns16550', 'ns16550'] is too long
	['fsl,ns16550', 'ns16550'] is too short
	'ns8250' was expected
	'ns16450' was expected
	'ns16550' was expected
	'ns16550a' was expected
	'ns16850' was expected
	'aspeed,ast2400-vuart' was expected
	'aspeed,ast2500-vuart' was expected
	'intel,xscale-uart' was expected
	'mrvl,pxa-uart' was expected
	'nuvoton,wpcm450-uart' was expected
	'nuvoton,npcm750-uart' was expected
	'nvidia,tegra20-uart' was expected
	'nxp,lpc3220-uart' was expected
	'fsl,ns16550' is not one of ['exar,xr16l2552', 'exar,xr16l2551', 'exar,xr16l2550']
	'fsl,ns16550' is not one of ['ns16750', 'cavium,octeon-3860-uart', 'xlnx,xps-uart16550-2.00.b', 'ralink,rt2880-uart']
	'fsl,ns16550' is not one of ['nuvoton,npcm845-uart']
	'fsl,ns16550' is not one of ['ralink,mt7620a-uart', 'ralink,rt3052-uart', 'ralink,rt3883-uart']
	'fsl,ns16550' is not one of ['mediatek,mt7622-btif', 'mediatek,mt7623-btif']
	'mrvl,mmp-uart' was expected
	'fsl,ns16550' is not one of ['nvidia,tegra30-uart', 'nvidia,tegra114-uart', 'nvidia,tegra124-uart', 'nvidia,tegra210-uart', 'nvidia,tegra186-uart', 'nvidia,tegra194-uart', 'nvidia,tegra234-uart']
	'ralink,rt2880-uart' was expected
	'mediatek,mtk-btif' was expected
	from schema $id: http://devicetree.org/schemas/serial/8250.yaml#
arch/powerpc/boot/dts/lancom-nwapp2.dtb: /immr@...00000/crypto@...00: failed to match any schema with compatible: ['fsl,sec3.3', 'fsl,sec3.1', 'fsl,sec3.0', 'fsl,sec2.4', 'fsl,sec2.2', 'fsl,sec2.1', 'fsl,sec2.0']
arch/powerpc/boot/dts/lancom-nwapp2.dtb: /immr@...00000/crypto@...00: failed to match any schema with compatible: ['fsl,sec3.3', 'fsl,sec3.1', 'fsl,sec3.0', 'fsl,sec2.4', 'fsl,sec2.2', 'fsl,sec2.1', 'fsl,sec2.0']
arch/powerpc/boot/dts/lancom-nwapp2.dtb: /immr@...00000/crypto@...00: failed to match any schema with compatible: ['fsl,sec3.3', 'fsl,sec3.1', 'fsl,sec3.0', 'fsl,sec2.4', 'fsl,sec2.2', 'fsl,sec2.1', 'fsl,sec2.0']
arch/powerpc/boot/dts/lancom-nwapp2.dtb: /immr@...00000/crypto@...00: failed to match any schema with compatible: ['fsl,sec3.3', 'fsl,sec3.1', 'fsl,sec3.0', 'fsl,sec2.4', 'fsl,sec2.2', 'fsl,sec2.1', 'fsl,sec2.0']
arch/powerpc/boot/dts/lancom-nwapp2.dtb: /immr@...00000/crypto@...00: failed to match any schema with compatible: ['fsl,sec3.3', 'fsl,sec3.1', 'fsl,sec3.0', 'fsl,sec2.4', 'fsl,sec2.2', 'fsl,sec2.1', 'fsl,sec2.0']
arch/powerpc/boot/dts/lancom-nwapp2.dtb: /immr@...00000/crypto@...00: failed to match any schema with compatible: ['fsl,sec3.3', 'fsl,sec3.1', 'fsl,sec3.0', 'fsl,sec2.4', 'fsl,sec2.2', 'fsl,sec2.1', 'fsl,sec2.0']
arch/powerpc/boot/dts/lancom-nwapp2.dtb: /immr@...00000/crypto@...00: failed to match any schema with compatible: ['fsl,sec3.3', 'fsl,sec3.1', 'fsl,sec3.0', 'fsl,sec2.4', 'fsl,sec2.2', 'fsl,sec2.1', 'fsl,sec2.0']
arch/powerpc/boot/dts/lancom-nwapp2.dtb: /immr@...00000/timer@500: failed to match any schema with compatible: ['fsl,mpc8315-gtm', 'fsl,gtm']
arch/powerpc/boot/dts/lancom-nwapp2.dtb: /immr@...00000/timer@500: failed to match any schema with compatible: ['fsl,mpc8315-gtm', 'fsl,gtm']
arch/powerpc/boot/dts/lancom-nwapp2.dtb: /immr@...00000/timer@600: failed to match any schema with compatible: ['fsl,mpc8315-gtm', 'fsl,gtm']
arch/powerpc/boot/dts/lancom-nwapp2.dtb: /immr@...00000/timer@600: failed to match any schema with compatible: ['fsl,mpc8315-gtm', 'fsl,gtm']
arch/powerpc/boot/dts/lancom-nwapp2.dtb: /immr@...00000/ipic-msi@7c0: failed to match any schema with compatible: ['fsl,ipic-msi']
arch/powerpc/boot/dts/lancom-nwapp2.dtb: /immr@...00000/power@b00: failed to match any schema with compatible: ['fsl,mpc8315-pmc', 'fsl,mpc8313-pmc', 'fsl,mpc8349-pmc']
arch/powerpc/boot/dts/lancom-nwapp2.dtb: /immr@...00000/power@b00: failed to match any schema with compatible: ['fsl,mpc8315-pmc', 'fsl,mpc8313-pmc', 'fsl,mpc8349-pmc']
arch/powerpc/boot/dts/lancom-nwapp2.dtb: /immr@...00000/power@b00: failed to match any schema with compatible: ['fsl,mpc8315-pmc', 'fsl,mpc8313-pmc', 'fsl,mpc8349-pmc']
arch/powerpc/boot/dts/lancom-nwapp2.dtb: /pci@...08500: failed to match any schema with compatible: ['fsl,mpc8349-pci']
arch/powerpc/boot/dts/lancom-nwapp2.dtb: /pcie@...09000: failed to match any schema with compatible: ['fsl,mpc8315-pcie', 'fsl,mpc8314-pcie']
arch/powerpc/boot/dts/lancom-nwapp2.dtb: /pcie@...09000: failed to match any schema with compatible: ['fsl,mpc8315-pcie', 'fsl,mpc8314-pcie']
arch/powerpc/boot/dts/lancom-nwapp2.dtb: /pcie@...0a000: failed to match any schema with compatible: ['fsl,mpc8315-pcie', 'fsl,mpc8314-pcie']
arch/powerpc/boot/dts/lancom-nwapp2.dtb: /pcie@...0a000: failed to match any schema with compatible: ['fsl,mpc8315-pcie', 'fsl,mpc8314-pcie']
arch/powerpc/boot/dts/lancom-nwapp2.dtb: gpio-watchdog: $nodename:0: 'gpio-watchdog' does not match '^(timer|watchdog)(@.*|-([0-9]|[1-9][0-9]+))?$'
	from schema $id: http://devicetree.org/schemas/watchdog/linux,wdt-gpio.yaml#
arch/powerpc/boot/dts/lancom-nwapp2.dtb: led-power: $nodename:0: 'led-power' does not match '^multi-led(@[0-9a-f])?$'
	from schema $id: http://devicetree.org/schemas/leds/leds-group-multicolor.yaml#
arch/powerpc/boot/dts/lancom-nwapp2.dtb: led-power: Unevaluated properties are not allowed ('color', 'function', 'label' were unexpected)
	from schema $id: http://devicetree.org/schemas/leds/leds-group-multicolor.yaml#
arch/powerpc/boot/dts/lancom-nwapp2.dtb: led-wlan-link: $nodename:0: 'led-wlan-link' does not match '^multi-led(@[0-9a-f])?$'
	from schema $id: http://devicetree.org/schemas/leds/leds-group-multicolor.yaml#
arch/powerpc/boot/dts/lancom-nwapp2.dtb: led-wlan-link: Unevaluated properties are not allowed ('color', 'function', 'label' were unexpected)
	from schema $id: http://devicetree.org/schemas/leds/leds-group-multicolor.yaml#
arch/powerpc/boot/dts/lancom-nwapp2.dtb: led-wlan-data: $nodename:0: 'led-wlan-data' does not match '^multi-led(@[0-9a-f])?$'
	from schema $id: http://devicetree.org/schemas/leds/leds-group-multicolor.yaml#
arch/powerpc/boot/dts/lancom-nwapp2.dtb: led-wlan-data: Unevaluated properties are not allowed ('color', 'label' were unexpected)
	from schema $id: http://devicetree.org/schemas/leds/leds-group-multicolor.yaml#
arch/powerpc/boot/dts/lancom-nwapp2.dtb: led-eth: $nodename:0: 'led-eth' does not match '^multi-led(@[0-9a-f])?$'
	from schema $id: http://devicetree.org/schemas/leds/leds-group-multicolor.yaml#
arch/powerpc/boot/dts/lancom-nwapp2.dtb: led-eth: Unevaluated properties are not allowed ('color', 'label' were unexpected)
	from schema $id: http://devicetree.org/schemas/leds/leds-group-multicolor.yaml#
arch/powerpc/boot/dts/lancom-nwapp2.dtb: led-power-top: $nodename:0: 'led-power-top' does not match '^multi-led(@[0-9a-f])?$'
	from schema $id: http://devicetree.org/schemas/leds/leds-group-multicolor.yaml#
arch/powerpc/boot/dts/lancom-nwapp2.dtb: led-power-top: Unevaluated properties are not allowed ('color', 'function', 'label' were unexpected)
	from schema $id: http://devicetree.org/schemas/leds/leds-group-multicolor.yaml#
arch/powerpc/boot/dts/lancom-nwapp2.dtb: led-wlan-top: $nodename:0: 'led-wlan-top' does not match '^multi-led(@[0-9a-f])?$'
	from schema $id: http://devicetree.org/schemas/leds/leds-group-multicolor.yaml#
arch/powerpc/boot/dts/lancom-nwapp2.dtb: led-wlan-top: Unevaluated properties are not allowed ('color', 'label' were unexpected)
	from schema $id: http://devicetree.org/schemas/leds/leds-group-multicolor.yaml#

Powered by blists - more mailing lists