linux-kernel - Re: [PATCH 1/2] module: get symbol crc back to unsigned

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAK7LNAQqvkRL7BDKW=tCxFatU01t268adsu5VXW1ZRWBQnCq4w@mail.gmail.com>
Date: Sat, 4 Jan 2025 01:03:47 +0900
From: Masahiro Yamada <masahiroy@...nel.org>
To: Petr Pavlu <petr.pavlu@...e.com>
Cc: linux-kbuild@...r.kernel.org, linux-kernel@...r.kernel.org, 
	Luis Chamberlain <mcgrof@...nel.org>, Sami Tolvanen <samitolvanen@...gle.com>, 
	Daniel Gomez <da.gomez@...sung.com>, linux-modules@...r.kernel.org, 
	Ard Biesheuvel <ardb@...nel.org>, Matthew Maurer <mmaurer@...gle.com>
Subject: Re: [PATCH 1/2] module: get symbol crc back to unsigned

On Mon, Dec 30, 2024 at 11:02 PM Petr Pavlu <petr.pavlu@...e.com> wrote:
>
> On 12/28/24 16:45, Masahiro Yamada wrote:
> > Commit 71810db27c1c ("modversions: treat symbol CRCs as 32 bit
> > quantities") changed the CRC fields to s32 because the __kcrctab and
> > __kcrctab_gpl sections contained relative references to the actual
> > CRC values stored in the .rodata section when CONFIG_MODULE_REL_CRCS=y.
> >
> > Commit 7b4537199a4a ("kbuild: link symbol CRCs at final link, removing
> > CONFIG_MODULE_REL_CRCS") removed this complexity. Now, the __kcrctab
> > and __kcrctab_gpl sections directly contain the CRC values in all cases.
> >
> > The genksyms tool outputs unsigned 32-bit CRC values, so u32 is preferred
> > over s32.
> >
> > No functional changes are intended.
> >
> > Regardless of this change, the CRC value is assigned to the u32 variable,
> > 'crcval' before the comparison, as seen in kernel/module/version.c:
> >
> >     crcval = *crc;
> >
> > Signed-off-by: Masahiro Yamada <masahiroy@...nel.org>
>
> Reviewed-by: Petr Pavlu <petr.pavlu@...e.com>
>
> I understand the plan is for this to go through the kbuild tree with the
> rest of the extended modversions + Rust support.


Yes.

Now applied to linux-kbuild.


-- 
Best Regards
Masahiro Yamada